Skip to content

Conversation

anisunity
Copy link
Contributor

@anisunity anisunity commented Sep 13, 2021

This makes sure that the cloud map's center is above (0,0,0)
https://fogbugz.unity3d.com/f/cases/resolve/1364465/

Testing status

Made sure the world center was at the middle of the pattern in the repro case.
image
I don't think any test will fail (not sure)

@anisunity anisunity added the HDRP label Sep 13, 2021
@anisunity anisunity requested review from a team and sebastienlagarde September 13, 2021 09:33
@anisunity anisunity self-assigned this Sep 13, 2021
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@JMargevics
Copy link
Contributor

Subtracting 0.5 seem a pretty straightforward fix and if repro case works correctly now, no additional testing is required ✔

@anisunity anisunity marked this pull request as ready for review September 14, 2021 08:44
@sebastienlagarde sebastienlagarde merged commit eac5425 into master Sep 15, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/fix-1364465 branch September 15, 2021 08:12
sebastienlagarde pushed a commit that referenced this pull request Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants