Skip to content

Fixed the volumetric clouds cloud map not being centered over the world origin (case 1364465). #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Fixed the volumetric clouds cloud map not being centered over the world origin (case 1364465). #5621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb40a6
Fixed the volumetric clouds cloud map not being centered over the wor…
anisunity Sep 13, 2021
1d0a061
Merge branch 'master' into HDRP/fix-1364465
sebastienlagarde Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed missing context menu for “Post Anti-Aliasing” in Camera (1357283)
- Fixed error when disabling opaque objects on a camera with MSAA.
- Fixed double camera preview.
- Fixed the volumetric clouds cloud map not being centered over the world origin (case 1364465).

### Changed
- Visual Environment ambient mode is now Dynamic by default.
Expand Down
4 changes: 2 additions & 2 deletions ...er-pipelines.high-definition/Runtime/Lighting/VolumetricLighting/VolumetricClouds.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ float3 AnimateFineNoisePosition(float3 positionPS)

void GetCloudCoverageData(float3 positionPS, out CloudCoverageData data)
{
// Convert the position into dome space
float2 normalizedPosition = AnimateCloudMapPosition(positionPS).xz / _NormalizationFactor * _CloudMapTiling.xy + _CloudMapTiling.zw;
// Convert the position into dome space and center the texture is centered above (0, 0, 0)
float2 normalizedPosition = AnimateCloudMapPosition(positionPS).xz / _NormalizationFactor * _CloudMapTiling.xy + _CloudMapTiling.zw - 0.5;
// Read the data from the texture
float4 cloudMapData = SAMPLE_TEXTURE2D_LOD(_CloudMapTexture, s_linear_repeat_sampler, float2(normalizedPosition), 0);
data.coverage = float2(cloudMapData.x, cloudMapData.x * cloudMapData.x);
Expand Down