[Fogbugz # 1365098] correct depth transparent lens flare #5658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1365098/
Lens flare was not binding global _CameraDepthTexture. This was sometimes left over bound as pyramid depth, which does not contain transparent depth geometry.
This could cause issues & inconsistencies between gameview (with full post process stack) & sceneview (no dof).
This was easily reproducible, by just adding transparent geo and a lens flare. If we enable "Depth Write" we expect the glass to occlude the lens flare. The expectation was otherwise not happening.
Testing status
Created a scene with a piece of glass and lens flare sun. Made the glass to have "Depth Write". Expected to have the lens flare occluded.
Before:

After:

Comments to reviewers
Notes for the reviewers you have assigned.