Skip to content

[Fogbugz # 1365098] correct depth transparent lens flare #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2021
Merged

[Fogbugz # 1365098] correct depth transparent lens flare #5658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51e29b3
Binding correct depth for lens flare. Depth bound was depth pyramid c…
kecho Sep 14, 2021
029ae5d
Changelog
kecho Sep 14, 2021
d3f5c91
Merge branch 'master' into HDRP/correct-depth-transparent-lens-flare
sebastienlagarde Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed a warning when enabling tile/cluster debug.
- Fix recursive rendering transmittance over the sky (case 1323945).
- Fixed specular anti aliasing for layeredlit shader.
- Fixed lens flare occlusion issues with transparent depth. It had the wrong depth bound (1365098)

### Changed
- Visual Environment ambient mode is now Dynamic by default.
Expand Down
8 changes: 6 additions & 2 deletions ...y.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.PostProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ TextureHandle RenderPostProcess(RenderGraph renderGraph,
// HDRP to reduce the amount of resolution lost at the center of the screen
source = PaniniProjectionPass(renderGraph, hdCamera, source);

source = LensFlareDataDrivenPass(renderGraph, hdCamera, source);
source = LensFlareDataDrivenPass(renderGraph, hdCamera, source, depthBuffer);

TextureHandle bloomTexture = BloomPass(renderGraph, hdCamera, source);
TextureHandle logLutOutput = ColorGradingPass(renderGraph, hdCamera);
Expand Down Expand Up @@ -3061,11 +3061,12 @@ class LensFlareData
{
public LensFlareParameters parameters;
public TextureHandle source;
public TextureHandle depthBuffer;
public HDCamera hdCamera;
public Vector2Int viewport;
}

TextureHandle LensFlareDataDrivenPass(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle source)
TextureHandle LensFlareDataDrivenPass(RenderGraph renderGraph, HDCamera hdCamera, TextureHandle source, TextureHandle depthBuffer)
{
if (m_LensFlareDataDataDrivenFS && !LensFlareCommonSRP.Instance.IsEmpty())
{
Expand All @@ -3075,6 +3076,7 @@ TextureHandle LensFlareDataDrivenPass(RenderGraph renderGraph, HDCamera hdCamera
passData.parameters = PrepareLensFlareParameters(hdCamera);
passData.viewport = postProcessViewportSize;
passData.hdCamera = hdCamera;
passData.depthBuffer = depthBuffer;
TextureHandle dest = GetPostprocessUpsampledOutputHandle(renderGraph, "Lens Flare Destination");

builder.SetRenderFunc(
Expand All @@ -3083,6 +3085,8 @@ TextureHandle LensFlareDataDrivenPass(RenderGraph renderGraph, HDCamera hdCamera
float width = (float)data.viewport.x;
float height = (float)data.viewport.y;

ctx.cmd.SetGlobalTexture(HDShaderIDs._CameraDepthTexture, data.depthBuffer);

LensFlareCommonSRP.DoLensFlareDataDrivenCommon(
data.parameters.lensFlareShader, data.parameters.lensFlares, data.hdCamera.camera, width, height,
data.parameters.usePanini, data.parameters.paniniDistance, data.parameters.paniniCropToFit,
Expand Down