Skip to content

Conversation

Nightmask3
Copy link
Contributor

@Nightmask3 Nightmask3 commented Sep 16, 2021


Purpose of this PR

Bugfix for: https://fogbugz.unity3d.com/f/cases/1357648/

Broken behavior:

VZLhKvOnIM.mp4

Fixed behavior:

pb4BeQzuEt.mp4

Testing status

Verified bug behavior no longer reproduces.

Also ensured that these related bugs to this issue aren't regressed by the fix:

https://fogbugz.unity3d.com/f/cases/1318844/
https://fogbugz.unity3d.com/f/cases/1327208/

(can see the behavior for the first bug listed verified in the fixed video above)

@Nightmask3 Nightmask3 requested a review from marctem September 16, 2021 22:25
@Nightmask3 Nightmask3 requested a review from a team as a code owner September 16, 2021 22:25
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@Nightmask3 Nightmask3 changed the title [ShaderGraph][2021.2][1357648] Fix bug that prevents switching to Graph Settings tab in Inspector when multiple nodes and edge are selected [ShaderGraph][2022.1][1357648] Fix bug that prevents switching to Graph Settings tab in Inspector when multiple nodes and edge are selected Sep 16, 2021
Copy link
Contributor

@GrantLamb-Unity GrantLamb-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being aware of and verifying the other issues did not regress

@jessebarker jessebarker merged commit 912dc64 into master Sep 17, 2021
@jessebarker jessebarker deleted the sg/fix-graph-settings-tab-bug-1357648 branch September 17, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants