Skip to content

Conversation

eturquin
Copy link
Contributor

@eturquin eturquin commented Sep 21, 2021

This PR addresses the following tickets, all related to volumetric scattering in path tracing:

The new version shows better convergence speed, and fixes the directional light intensity issue.
It also uses the fog color to produce a result similar to the non-volumetric one, and then adds volumetrically scattered contributions on top of it (which is IMHO a better behaviour than what the raster version does, whose computations I couldn't make sense of).

This has been tested on the scenes of the respective tickets, and on an additional test scene which mixes all kinds of lights (see screenshot below).

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@eturquin
Copy link
Contributor Author

volscat

@eturquin eturquin marked this pull request as ready for review September 22, 2021 15:52
@sebastienlagarde
Copy link
Contributor

For QA. I need to merge this PR for 21.2 but please do a review of it. thanks

@sebastienlagarde
Copy link
Contributor

For QA: this PR is also part of it and merged as well, so when you validate it include this one as well: #5798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants