-
Notifications
You must be signed in to change notification settings - Fork 855
[HDRP][Path Tracing] Improved volumetric scattering light sampling #5754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
For QA. I need to merge this PR for 21.2 but please do a review of it. thanks |
For QA: this PR is also part of it and merged as well, so when you validate it include this one as well: #5798 |
This PR addresses the following tickets, all related to volumetric scattering in path tracing:
The new version shows better convergence speed, and fixes the directional light intensity issue.
It also uses the fog color to produce a result similar to the non-volumetric one, and then adds volumetrically scattered contributions on top of it (which is IMHO a better behaviour than what the raster version does, whose computations I couldn't make sense of).
This has been tested on the scenes of the respective tickets, and on an additional test scene which mixes all kinds of lights (see screenshot below).