Skip to content

Conversation

eturquin
Copy link
Contributor

@eturquin eturquin commented Sep 24, 2021

One small change got lost somewhere, that should have been part of a recent PR on volumetric scattering (#5754).
It makes sure that the volume coloration, in a similar way to the non-volumetric case, is only applied to non volume-scattering contributions (for which the volume color is set to black, to conserve physicality).

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde sebastienlagarde merged commit 243e9f3 into master Sep 24, 2021
@sebastienlagarde sebastienlagarde deleted the hd/pt_vol_col_fix branch September 24, 2021 17:24
sebastienlagarde pushed a commit that referenced this pull request Sep 27, 2021
…olumetric scattering) (#5798)

* Do not use volume color on non-surface scattering.

* ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants