Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 22, 2021

Purpose of this PR

We recently bumped the utf version to 1.1.29, but the codecoverage package wasn't up to date and ready for this change, resulting in failures in the nightlies for packages using it (shadegraph). See slack thread here.
The fix is to update the code coverage package as well.


Testing status

Shadergraph pipeline

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopnv theopnv marked this pull request as ready for review September 22, 2021 16:57
@theopnv theopnv merged commit ac1bcca into 2021.2/staging Sep 22, 2021
@theopnv theopnv deleted the yamato/fix-codecoverage-errors branch September 22, 2021 16:58
theopnv pushed a commit that referenced this pull request Sep 23, 2021
theopnv pushed a commit that referenced this pull request Sep 23, 2021
theopnv pushed a commit that referenced this pull request Sep 23, 2021
theopnv pushed a commit that referenced this pull request Sep 23, 2021
* Revert "Revert "Bump utf to 1.1.29 (#5721)""

This reverts commit 9113fc3.

* Exclude HDRP_Tests (incompatible)

* Forward port #5764
theopnv pushed a commit that referenced this pull request Sep 24, 2021
* Backport #5764

* Disable templates pipeline in nightly for 10xx
theopnv pushed a commit that referenced this pull request Sep 30, 2021
* Disable templates pipeline in weeklyfor 7xx

* Backport #5764

* Revert utf bump for SG

* Revert all changes made to SG manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants