Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 20, 2021

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@theopnv
Copy link
Contributor Author

theopnv commented Sep 20, 2021

Errors unrelated to this PR.
The remaining perf tests (android, quest) should be fixed with another PR that landed in the meantime - see https://unity.slack.com/archives/CFZERNTS7/p1631784673078900

@theopnv theopnv marked this pull request as ready for review September 20, 2021 14:42
@theopnv theopnv requested a review from a team as a code owner September 20, 2021 14:42
@theopnv theopnv merged commit 8598e7c into master Sep 21, 2021
@theopnv theopnv deleted the tests/bump-utf-1.1.29 branch September 21, 2021 06:59
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theopnv theopnv mentioned this pull request Sep 21, 2021
theopnv pushed a commit that referenced this pull request Sep 21, 2021
@theopnv theopnv mentioned this pull request Sep 21, 2021
theopnv pushed a commit that referenced this pull request Sep 21, 2021
* Backport #5072

* Update README

* Backport #5653

* Backport #5627

* Backport #5721
theopnv pushed a commit that referenced this pull request Sep 21, 2021
* Backport #5653

* Backport #5721

* Backport #5753
sebastienlagarde added a commit that referenced this pull request Sep 21, 2021
theopnv pushed a commit that referenced this pull request Sep 22, 2021
theopnv pushed a commit that referenced this pull request Sep 22, 2021
* Revert #5721

* Revert SG file changes
theopnv pushed a commit that referenced this pull request Sep 23, 2021
theopnv pushed a commit that referenced this pull request Sep 23, 2021
* Revert "Revert "Bump utf to 1.1.29 (#5721)""

This reverts commit 9113fc3.

* Exclude HDRP_Tests (incompatible)

* Forward port #5764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants