[2021.2] Change android build image #5773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopnv
reviewed
Sep 23, 2021
| - cd TestProjects/BoatAttack && unity-config project add dependency com.unity.addressables@1.16.7 --project-path . | ||
| - cd TestProjects/BoatAttack && unity-config project add dependency com.unity.scriptablebuildpipeline@1.11.2 --project-path . | ||
| - cd TestProjects/BoatAttack && unity-config project add dependency com.unity.test-framework@1.1.18 --project-path . | ||
| - cd TestProjects/BoatAttack && unity-config project add dependency com.unity.test-framework@1.1.29 --project-path . |
There was a problem hiding this comment.
Thanks for this! 🤦🏻♂️ I think I forgot to regenerated the yml files in my previous PR #5741.....
There was a problem hiding this comment.
Causing the URP Perf tests to continue to fail
There was a problem hiding this comment.
Oh, I didn't notice it myself 😅 but I'm glad!
added 6 commits
September 23, 2021 12:15
sophiaaar
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Changes android build images to fix SDK error.
Testing status
ShaderGraph green
URP_2D green
URP_Foundation green
URP_Foundation XR Some failed tests
URP_Lighting green
Comments to reviewers
Reverted changes for all performance jobs, as they are trickier to fix and will be fixed in a separate PR not to block URP fixes. Keeping the jobs listed here though to refer while prepping the follow-up PR.
BoatAttack performance build editmode
BoatAttack performance playmode runtime
LostCrypt performance_playmode_runtime
LostCrypt performance_build_editmode
VV builtin performance_build_editmode
VV builtin performance_playmode_runtime
VV URP performance_build_editmode
VV URP performance_playmode_runtime