Skip to content

[VFX] Fix Edit Mode test #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

[VFX] Fix Edit Mode test #5776

merged 1 commit into from
Sep 27, 2021

Conversation

PaulDemeulenaere
Copy link
Contributor

Purpose of this PR

Fix an instability of a recently introduced test:

[307/1152] TestFinish
	name: UnityEditor.VFX.Test.VFXSerializationTests.Verify_Orphan_Dependencies_Are_Correctly_Cleared
	result: FAILED
	message: Method marked with UnityTest must return IEnumerator.
	duration: 0.002084 seconds```

---
### Testing status
Yamato ⏳ 

---
### Comments to reviewers
See this [conversation](https://unity.slack.com/archives/G1BTWN88Z/p1632382923203200)

@PaulDemeulenaere
Fix Verify_Orphan_Dependencies_Are_Correctly_Cleared
d134fa8 
Useless UnityTest with enumarable approach
@Unity-Technologies Unity-Technologies deleted a comment from github-actions bot Sep 23, 2021
@PaulDemeulenaere
Copy link
Contributor Author

The URP failure isn't related to this change, see this conversation

@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review September 23, 2021 13:13
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Sep 27, 2021
Merged
@sebastienlagarde sebastienlagarde merged commit b3ef8a1 into master Sep 27, 2021
@sebastienlagarde sebastienlagarde deleted the vfx/test/fix-incorrect-test-validation-verify_orphan_dependencies_are_correctly_cleared branch September 27, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulDemeulenaere @sebastienlagarde