Skip to content

[VFX] Fix Edit Mode test (to 2021.2) #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

[VFX] Fix Edit Mode test (to 2021.2) #5777

merged 1 commit into from
Sep 27, 2021

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Sep 23, 2021 •
edited
Loading

Purpose of this PR

Fix an instability of a recently introduced test:

[307/1152] TestFinish
	name: UnityEditor.VFX.Test.VFXSerializationTests.Verify_Orphan_Dependencies_Are_Correctly_Cleared
	result: FAILED
	message: Method marked with UnityTest must return IEnumerator.
	duration: 0.002084 seconds

#5776

Testing status

Yamato ⏳

Comments to reviewers

See this conversation
This is backport of #5776

@PaulDemeulenaere
Fix Verify_Orphan_Dependencies_Are_Correctly_Cleared
1838dfa 
Useless UnityTest with enumarable approach

(cherry picked from commit d134fa8)
@Unity-Technologies Unity-Technologies deleted a comment from github-actions bot Sep 23, 2021
@PaulDemeulenaere PaulDemeulenaere marked this pull request as ready for review September 23, 2021 13:13
@sebastienlagarde sebastienlagarde merged commit 0642fa7 into 2021.2/staging Sep 27, 2021
@sebastienlagarde sebastienlagarde deleted the 2021.2/vfx/test/fix-incorrect-test-validation-verify_orphan_dependencies_are_correctly_cleared branch September 27, 2021 16:01
PaulDemeulenaere added a commit that referenced this pull request Oct 6, 2021
@PaulDemeulenaere
Fix Verify_Orphan_Dependencies_Are_Correctly_Cleared (#5777)
54ad13b 
Useless UnityTest with enumarable approach

(cherry picked from commit d134fa8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testing vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulDemeulenaere @sebastienlagarde