[VFX] Fix inconsistent NeedsPositionWorldInterpolator #5784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common function to factorize the requirement test from SG Regression introduced by #5428
com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
Show resolved
Hide resolved
|
I'm switching back to draft while I'm improving this implementation: #5784 (comment) |
Isolate screen computation from the world dependancy See #5784 (comment) /!\ Remove the VFXTransformPositionWorldToClip evaluated in fragment /!\ GraphicTest are 🟢 locally
julienf-unity
approved these changes
Sep 24, 2021
com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
Outdated
Show resolved
Hide resolved
com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
Outdated
Show resolved
Hide resolved
If we want to be consistent with SG implementation, we have to reproduced this code: https://github.com/Unity-Technologies/Graphics/blob/75f4b421fa774d43000d703f2bbf05d7a1ca6606/com.unity.render-pipelines.universal/Editor/ShaderGraph/Templates/SharedCode.template.hlsl#L56 ``` $SurfaceDescriptionInputs.ScreenPosition: output.ScreenPosition = ComputeScreenPos(TransformWorldToHClip(input.positionWS), _ProjectionParams.x); ``` Checked manually the values were consistent with VFX
cdxntchou
approved these changes
Sep 24, 2021
cdxntchou
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Fix inconsistent NeedsPositionWorldInterpolator Use common function to factorize the requirement test from SG Regression introduced by #5428 * Better fix & Better performance Isolate screen computation from the world dependancy See #5784 (comment) /!\ Remove the VFXTransformPositionWorldToClip evaluated in fragment /!\ GraphicTest are 🟢 locally * Fix incorrect computation of INSG.ScreenPosition If we want to be consistent with SG implementation, we have to reproduced this code: https://github.com/Unity-Technologies/Graphics/blob/75f4b421fa774d43000d703f2bbf05d7a1ca6606/com.unity.render-pipelines.universal/Editor/ShaderGraph/Templates/SharedCode.template.hlsl#L56 ``` $SurfaceDescriptionInputs.ScreenPosition: output.ScreenPosition = ComputeScreenPos(TransformWorldToHClip(input.positionWS), _ProjectionParams.x); ``` Checked manually the values were consistent with VFX
|
Has been backported with #5817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix issue introduced at #5428
The condition which generates VFX_VARYING_POSWS wasn't consistent between defines & code generationExtract code which computes the ScreenPosition/PositionNDC from the WorldPosition dependency, it saves interpolator & computation when it isn't actually needed.
Testing status
Locally 🟢
Yamato ⏳
Comments to reviewers
See this conversation