Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Sep 27, 2021

Purpose of this PR

Backport of #5812.

  • Bumped SRP packages to 13.1.0
  • Moved some release notes to the new section, as they were added after the commit used for the current vendoring (and therefore correspond to the next vendoring).

Testing status

Pack & Test all packages (upm-ci validation): https://unity-ci.cds.internal.unity3d.com/project/902/branch/2021.2%2Fsrp%2Fbump-packages/jobDefinition/.yamato%2F_projectcontext.yml%23all_package_ci_project_2021.2

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_2021.2

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_2021.2

VFX
/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/.yamato%252F_abv.yml%2523all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is also documentation.cs to bump and version.hlsl. (yes bumping is a nightmare :) )

@theopnv
Copy link
Contributor Author

theopnv commented Sep 29, 2021

Applied requested changes @sebastienlagarde, thanks.
Removed all modifications made to the templates (except the hdrp or urp version they're using), as you are already bumping them in other PRs #5799.

@theopnv theopnv marked this pull request as ready for review September 29, 2021 10:01
@theopnv theopnv requested review from a team as code owners September 29, 2021 10:01
@sebastienlagarde sebastienlagarde merged commit b412df7 into 2021.2/staging Sep 30, 2021
@sebastienlagarde sebastienlagarde deleted the 2021.2/srp/bump-packages branch September 30, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants