Skip to content

Conversation

joshua-davis
Copy link
Contributor

…the current text size. Fixes fogbugz 1357657

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you updated the changelog? Each package has a CHANGELOG.md file.

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1357657/
The input text for a sticky-note's title text was always at the smallest text size, even if you changed the font size to huge.


Testing status

Created a sticky note tried editing the title and contents at all 4 sizes (small, medium, large, huge) and verified that the font size was always equal between editable and non-editable.

- Original Title Contents
Small image image image
Medium image image image
Large image image image
Huge image image image

Comments to reviewers

The issue was the uss didn't recursively set this on the title text, which is how the contents works.

…the current text size. Fixes fogbugz 1357657
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@joshua-davis joshua-davis requested review from a team and Nightmask3 September 28, 2021 14:27
@joshua-davis joshua-davis marked this pull request as ready for review September 28, 2021 14:27
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nightmask3 Nightmask3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving!

Copy link
Contributor

@bencloward bencloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out and it's working great. Ship it!

@joshua-davis joshua-davis merged commit abce09f into master Sep 29, 2021
@joshua-davis joshua-davis deleted the sg/stickynote-title-text-size branch September 29, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants