Skip to content

Conversation

remi-chapelain
Copy link
Contributor

Purpose of this PR

This PR fixes this issue. The setup was fine but the text was misleading.
This PR now shows different scale setup with correctly adjusted world scale diffusion profile.

The text has been changed accordingly and it has been added that this graph is made only for this model and at this import scale factor to avoid possible confusions.

image

Eyeballs have a diameter of roughly 25mm. To use the diffusion profiles at a realistic scale, the world scale in the diffusion profiles needs to be adjusted accordingly. In this sample, the diffusion profiles world scale accommodates for eyeballs that have different diameters.

This graph is specifically made for this model with an import scale factor of one. A different graph needs to be created when using different models or scale factor.

To create lighting that works with small objects, use punctual lights instead of directional lights.


Testing status

Loaded the sample into a fresh project. ✔️
Checked the other sample scenes visually to see if something was different. ✔️


Comments to reviewers

🤷

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@remi-chapelain remi-chapelain marked this pull request as ready for review September 29, 2021 09:55
Copy link
Contributor

@anisunity anisunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair validated during the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants