[HDRP] Reenable crossfade on the HD SpeedTree 8 shader. #5957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Oct 12, 2021
TomasKiniulis
approved these changes
Oct 13, 2021
|
Unable to verify the fix using: and
Have pinged @tian-unity directly. |
|
I wasn't able to reproduce the issues David was seeing with the information I got from him. Since this fix is fairly self-contained and Tomas was able to confirm it, is it ok to merge anyways? |
sebastienlagarde
pushed a commit
that referenced
this pull request
Oct 18, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Oct 18, 2021
* Fixed initial decal position #5889 * Fix APV issue spewing asserts when baking with max subdiv level of 2 (#5888) * Add override checkbox. * Fix for problem when max subdiv is smaller than index voxel update size. * Revert "Merge branch 'HDRP/add-override-checkbox-for-pv' into HDRP/investigate-issue-with-faulty-index" This reverts commit e33a421, reversing changes made to 924763f. * Skip refresh ops if feature is disabled. (#5886) * Fixed the clouds not taking properly into account the fog when in distant mode and with a close far plane (case 1367993). (#5884) * Fixed the clouds not taking properly into account the fog when in distant mode and with a close far plane (case 1367993). * Fix formatting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * To info box (#5879) * Add override checkbox. (#5878) * corrected links to HDAdditionalLightData and HDLightTypeAndShape (#5861) * updated link to expert guide (#5857) * Add comment (#5853) * [HDRP][Path Tracing] Added selection of light types for Unlit shadow mattes. #5855 * Maintain APV cells loaded if at least one scene still references that cell (#5900) * Add override checkbox. * Fix for problem when max subdiv is smaller than index voxel update size. * Revert "Merge branch 'HDRP/add-override-checkbox-for-pv' into HDRP/investigate-issue-with-faulty-index" This reverts commit e33a421, reversing changes made to 924763f. * Add a basic APV test to runtime tests (#5952) * New test * Tentative ref images * Change threshold to be non-zero. * Forgot one threshold... * Add test filter. * [HDRP] APV - Fix voxelization issues with planes at the origin (#5897) * Fix precision issues with the scene voxelization, especially with geometry at the origin. * Updated changelog * Fix renderer bounds for the plane case * disable debug * rename epsilon Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> * Fix another issue with probe volume subdiv multiplier when changing to a lower subdiv level (#5893) * Add override checkbox. * Fix for problem when max subdiv is smaller than index voxel update size. * Revert "Merge branch 'HDRP/add-override-checkbox-for-pv' into HDRP/investigate-issue-with-faulty-index" This reverts commit e33a421, reversing changes made to 924763f. * Fix issue * Revert "Fix for problem when max subdiv is smaller than index voxel update size." This reverts commit 03feabd. * Fixed the volumetric clouds debug view not taking into account the exposure and leading to Nans (case 1365054). (#5940) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Change order of fields in the cbuffer. (#5980) Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> * Fixed the dependency between transparent SSR and transparent depth prepass being implicit (case 1365915). (#5898) * Fixed the dependency between transparent SSR and transparent depth prepass being implicit (case 1365915). * review corrections Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Updating docs for merged PRs (#5821) * PR #5459 Updated the docs changed in "Add high quality antialiasing example using the accumulation api" PR. * Doc fixes Fixed typo and changed SuperSampling "effect" to "method" Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Fogbugz # 1365687] Fixing depth pyramid with multicamera on hardware drs. #5902 * Fix (#5994) * release cmd (#5993) * test linux vulkan and OSX filter out. (#5989) * Fixed removal of depth buffer binding (#5910) * Fixed removal of depth buffer binding * Add object in graphic test * screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP][Path Tracing] Added orthographic camera support #5944 * Fixed a regression in the transparent SSR color pyramid usage. (#6001) * Fixed a regression in the transparent SSR color pyramid usage. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Reenable crossfade on the HD SpeedTree 8 shader. #5957 * Force scalarization of shadow index data off (#6007) * Fixes for light anchor #5915 * Minor performance improvements to SSGI (case 1367144). #5921 * Update TestCaseFilters.asset Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: FrancescoC-Unity <francescoc@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Tianliang Ning <paula.s.ning@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
At some point, a toggle for LOD crossfade was added to the HD Lit target. It's off by default, which disabled crossfading on the SpeedTree 8 shadergraph. Re-enable crossfade.
Testing status
Confirmed crossfade works on speed trees again.
Comments to reviewers
I know this is broken on 12.x.x (since that's where the speedtree folks found it). Does 21.1 and 10.x.x also need a backport? When did this target toggle get added?