Skip to content

Conversation

kivistikliis
Copy link
Contributor

Purpose of this PR

Change to using refactored Yamato jobs. Instead of having several .yml files requiring manual editing, the refactored version makes it easier to introduce changes (adding platforms, apis etc to projects, or adding jobs to nightly, etc.). The refactor uses Python and Ruamel (fork of PyYAML) to create all .yml files based on the input/configuration found under .yamato/ruamel/config/*.metafile.

Docs on this can be found in devs-graphics-packages channel.

Testing status

All refactored .yml files have been compared/verified with either YAML diff tool or ci-linter against the current .yml jobs in master. Several jobs are tested in Yamato, here is nightly (some jobs have failed due to changes outside this refactor): https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Frefactor-ruamel/.yamato%252F_abv.yml%2523all_project_ci_nightly_trunk/2293752/job/pipeline

Links

Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Frefactor-ruamel

@kivistikliis kivistikliis requested a review from sophiaaar May 25, 2020 15:42
@kivistikliis kivistikliis requested review from a team, sebastienlagarde and stramit May 25, 2020 15:53
@kivistikliis kivistikliis marked this pull request as ready for review May 27, 2020 08:06
Copy link
Contributor

@sebastienlagarde sebastienlagarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, givven the number of files adddeds shouldn't we create folder? (Maybe it is not possible).
Or maybe moved all python script in a .python and have .yamato being only the generated file?
Also maybe a folder per package with all the platforms, just random idea based on all the files at the root folder.

@sophiaaar
Copy link
Contributor

@sebastienlagarde the yml files have to be directly in .yamato folder otherwise Yamato doesn't recognise them, unfortunately. the other ruamel files are sorted into folders though

@sophiaaar
Copy link
Contributor

besides, the new workflow is that you shouldnt ever edit the yml directly, so it should be fine :)

@sophiaaar
Copy link
Contributor

rerunning the failed hdrp jobs using a previous unity revision as trunk has broken us (being fixed in a different pr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants