-
Notifications
You must be signed in to change notification settings - Fork 855
Refactored Yamato jobs #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit b19a2e9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment, givven the number of files adddeds shouldn't we create folder? (Maybe it is not possible).
Or maybe moved all python script in a .python and have .yamato being only the generated file?
Also maybe a folder per package with all the platforms, just random idea based on all the files at the root folder.
@sebastienlagarde the yml files have to be directly in .yamato folder otherwise Yamato doesn't recognise them, unfortunately. the other ruamel files are sorted into folders though |
besides, the new workflow is that you shouldnt ever edit the yml directly, so it should be fine :) |
rerunning the failed hdrp jobs using a previous unity revision as trunk has broken us (being fixed in a different pr) |
Purpose of this PR
Change to using refactored Yamato jobs. Instead of having several .yml files requiring manual editing, the refactored version makes it easier to introduce changes (adding platforms, apis etc to projects, or adding jobs to nightly, etc.). The refactor uses Python and Ruamel (fork of PyYAML) to create all .yml files based on the input/configuration found under .yamato/ruamel/config/*.metafile.
Docs on this can be found in devs-graphics-packages channel.
Testing status
All refactored .yml files have been compared/verified with either YAML diff tool or ci-linter against the current .yml jobs in master. Several jobs are tested in Yamato, here is nightly (some jobs have failed due to changes outside this refactor): https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Frefactor-ruamel/.yamato%252F_abv.yml%2523all_project_ci_nightly_trunk/2293752/job/pipeline
Links
Yamato: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/yamato%252Frefactor-ruamel