-
Notifications
You must be signed in to change notification settings - Fork 855
[backport] 7.x.x/backports/yamato/ruamel refactor #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] 7.x.x/backports/yamato/ruamel refactor #880
Conversation
Some jobs and/or dependencies on 7.x.x are not in sync with master, the PR will be marked ready when its decided what to sync and what not |
.yamato/_abv.yml
Outdated
- path: .yamato/universal-android-opengles3.yml#Universal_Android_OpenGLES3_Standalone_2019.3 | ||
rerun: on-new-revision | ||
- path: .yamato/universal-android-vulkan.yml#Universal_Android_Vulkan_Standalone_2019.3 | ||
rerun: on-new-revision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android targets arent running on 7.x.x/release. i think we should exclude them from this backport PR and add them back in at another time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved this with the last commit
.yamato/all-hdrp.yml
Outdated
- path: .yamato/hdrp_dxr-win-dx12.yml#HDRP_DXR_Win_DX12_playmode_2019.3 | ||
rerun: on-new-revision |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure if DXR will work on 2019.3 - @theo-pnv could you look into this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't know if DXR works for 2019.3 but in any case, it's not part of the All HDRP CI pipeline, for 7.x.x and 8.x.x (see here https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Frelease/.yamato%252Fupm-ci-hdrp.yml%2523All_HDRP_2019.3/2502558/job/pipeline VS for master https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/master/.yamato%252Fall-hdrp.yml%2523All_HDRP_trunk/2498833/job/pipeline)
(I hope I'm looking at the right places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed it with the last commit!
Removed opengl from player settings, in order for metal tests to work for the hdrp project.
- Linux and osx not supported by 7.x.x
moved to #1031 |
Purpose of this PR
Backporting refactored Yamato jobs, which are now generated via Python/ruamel script. Original backport PR is #598, but as it has received several updates since then, the refactor was taken straight from the latest master instead of cherrypicking.
Testing status
Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fbackports%252Fyamato%252Fruamel-refactor