Skip to content

Conversation

kivistikliis
Copy link
Contributor


Purpose of this PR

Backporting refactored Yamato jobs, which are now generated via Python/ruamel script. Original backport PR is #598, but as it has received several updates since then, the refactor was taken straight from the latest master instead of cherrypicking.


Testing status

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics/tree/7.x.x%252Fbackports%252Fyamato%252Fruamel-refactor

@kivistikliis kivistikliis requested a review from sophiaaar June 12, 2020 11:25
@kivistikliis
Copy link
Contributor Author

Some jobs and/or dependencies on 7.x.x are not in sync with master, the PR will be marked ready when its decided what to sync and what not

.yamato/_abv.yml Outdated
Comment on lines 103 to 106
- path: .yamato/universal-android-opengles3.yml#Universal_Android_OpenGLES3_Standalone_2019.3
rerun: on-new-revision
- path: .yamato/universal-android-vulkan.yml#Universal_Android_Vulkan_Standalone_2019.3
rerun: on-new-revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android targets arent running on 7.x.x/release. i think we should exclude them from this backport PR and add them back in at another time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved this with the last commit

Comment on lines 33 to 34
- path: .yamato/hdrp_dxr-win-dx12.yml#HDRP_DXR_Win_DX12_playmode_2019.3
rerun: on-new-revision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if DXR will work on 2019.3 - @theo-pnv could you look into this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it with the last commit!

Sophia and others added 5 commits June 16, 2020 16:43
@kivistikliis
Copy link
Contributor Author

moved to #1031

@kivistikliis kivistikliis deleted the 7.x.x/backports/yamato/ruamel-refactor branch July 1, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants