Skip to content

Conversation

adrien-de-tocqueville
Copy link
Contributor

@adrien-de-tocqueville adrien-de-tocqueville commented Oct 14, 2021

Purpose of this PR

add section in what's new for #5761

Also add what's new for main light node #5086

@github-actions
Copy link

github-actions bot commented Oct 14, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the HDRP label Oct 14, 2021
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@sebastienlagarde
Copy link
Contributor

@adrien-de-tocqueville guess you will need to create a Jira task?

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added re-write suggestions in comments. Changed the order of information to make the new feature more clear :)

@adrien-de-tocqueville adrien-de-tocqueville requested a review from a team as a code owner November 8, 2021 14:32
@adrien-de-tocqueville
Copy link
Contributor Author

i forgot to add the new node to the table of content for shadergraph doc. So i did it in this PR

@sebastienlagarde
Copy link
Contributor

Feedback adressed, merging

@sebastienlagarde sebastienlagarde merged commit 1069e8d into master Nov 22, 2021
@sebastienlagarde sebastienlagarde deleted the hd/material-api-whatsnew branch November 22, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants