Skip to content

Made property row labels flexible #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2020
Merged

Made property row labels flexible #604

merged 4 commits into from
May 27, 2020

Conversation

alelievr
Copy link
Member

@alelievr alelievr commented May 26, 2020 •
edited
Loading

Purpose of this PR

  • Flexible label width in inspector
  • fixed indentlevel with padding instead of spaces (now word wrap works)
  • reduced the padding between labels to match the builtin inspector
  • added a globalIndentLevel to help to control the indent level in blocks
  • added a new style for target foldout making them stand out a bit more (like headers of the builtin inspector)

Old layout:

image

New layout:

image
PropertyRowPadding

@alelievr alelievr requested review from a team as code owners May 26, 2020 09:28
@alelievr alelievr self-assigned this May 26, 2020
alindmanUnity
alindmanUnity approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@alindmanUnity alindmanUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright to me, but please confirm that Universal still compiles and functions as expected with these changes

@alelievr
Copy link
Member Author

Tested with Universal and it works correctly

@alelievr alelievr mentioned this pull request May 27, 2020
Merged
@alindmanUnity alindmanUnity merged commit 54eabca into sg/master-stack May 27, 2020
@alindmanUnity alindmanUnity deleted the sg/flexible-property-row branch May 27, 2020 16:16
sebastienlagarde added a commit that referenced this pull request Nov 29, 2021
@sebastienlagarde
Revert "[HDRP] Adding transparency setup scenes to material sample (#604
aa72a2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alindmanUnity alindmanUnity alindmanUnity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alelievr alelievr

Labels

Shader Graph

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alelievr @alindmanUnity