Skip to content

[Ruby][ShaderGraph] Update Searcher package dependency to 4.9.1 #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2021
Merged

[Ruby][ShaderGraph] Update Searcher package dependency to 4.9.1 #6139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
430217d
fixes to not return category on empty query if child item is available
Nightmask3 Oct 8, 2021
e2a35a3
Merge branch 'master' into sg/fix-searcher-bugs-ruby
Nightmask3 Oct 25, 2021
19495a9
added changelog
Nightmask3 Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions com.unity.shadergraph/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,14 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Changed
- Changed the title suffix on old nodes and properties rom "Deprecated" to "Legacy".
- Updated searcher package dependency version to 4.9.1

### Fixed
- Fixed a usability issue where in some cases searcher would suggest one collapsed category of results that user would have to manually expand anyway
- Fixed bug that causes search results to not be visible sometimes in the searcher window [1366061]
- Fixed bug that causes exceptions to be thrown when using the up/down arrow keys with search list focused [1358016]
- Fixed bug that causes some searcher items to be irreversibly collapsed due to expand icon disappearing on collapsing those items [1366074]
- Fixed bug that caused incorrect search results with non whitespaced queries for nodes with spaces in their name and for subgraphs [1359158]
- Fixed Triplanar ShaderGraph node to handle arbitrary input and output coordinate spaces [1346477] (https://issuetracker.unity3d.com/issues/shader-graph-rotating-gameobject-get-material-stretched-when-using-triplanar-node)
- Fixed a bug that Parallax Mapping and Parallax Occlusion Mapping nodes don't use the same channel to sample heightmap by adding drop-downs for channel selecting to both of the nodes. [1347270] (https://fogbugz.unity3d.com/f/cases/1347270/)
- Fixed errors in the ShaderGraph Transform node [1368082]
Expand Down
2 changes: 1 addition & 1 deletion com.unity.shadergraph/Editor/Drawing/SearchWindowAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ private int ComputeScoreForMatch(string[] queryTerms, SearcherItem matchItem)
public override SearcherItem OnSearchResultsFilter(IEnumerable<SearcherItem> searchResults, string searchQuery)
{
if (searchQuery.Length == 0)
return searchResults.FirstOrDefault();
return GetFirstChildItem(searchResults.FirstOrDefault());

// Sort results by length so that shorter length results are prioritized
// prevents entries with short names getting stuck at end of list after entries with longer names when both contain the same word
Expand Down
2 changes: 1 addition & 1 deletion com.unity.shadergraph/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"displayName": "Shader Graph",
"dependencies": {
"com.unity.render-pipelines.core": "13.1.1",
"com.unity.searcher": "4.8.0"
"com.unity.searcher": "4.9.1"
},
"samples": [
{
Expand Down