Skip to content

Conversation

Nightmask3
Copy link
Contributor


Purpose of this PR

This PR is meant to update the searcher package dependency SG relies on to 4.9.1, and in doing so, fixes these bugs:

https://fogbugz.unity3d.com/f/cases/1358016/
https://fogbugz.unity3d.com/f/cases/1366074/
https://fogbugz.unity3d.com/f/cases/1366061/
https://fogbugz.unity3d.com/f/cases/1359158/

2021.2 Backport: #6138


Testing status

Verified that the above bugs no longer repro.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Nightmask3 Nightmask3 marked this pull request as ready for review October 26, 2021 00:00
@Nightmask3 Nightmask3 requested a review from a team as a code owner October 26, 2021 00:00
Copy link
Contributor

@esmelusina esmelusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here, assuming Grant is double checking that the version bump itself doesn't break things.

Copy link
Contributor

@GrantLamb-Unity GrantLamb-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran some basic tests around verifying the fixes. Also had a zoom conversation with Sai about some general process questions when it comes to how the SG team tests their work. Based on these I'm approving 👍

@Nightmask3
Copy link
Contributor Author

image
The one failing job is also failing on master and is generally unstable, will follow up with #devs-graphics-automation to find out whats going on

@marctem marctem merged commit 45d1e8c into master Oct 29, 2021
@marctem marctem deleted the sg/fix-searcher-bugs-ruby branch October 29, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants