Skip to content

Update 2DRendererData_overview.md #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2021
Merged

Update 2DRendererData_overview.md #6272

merged 3 commits into from
Dec 9, 2021

Conversation

unity-cchu
Copy link
Contributor

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.

Purpose of this PR

This adds additional documentation about how to use the _CameraSortingLayerTexture shader variable

@unity-cchu unity-cchu requested review from a team as code owners November 11, 2021 05:42
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@unity-cchu unity-cchu requested a review from Sam-Unity November 11, 2021 05:42
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Sam-Unity
Sam-Unity requested changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@Sam-Unity Sam-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest combining previous sentence with new line.

unity-cchu and others added 2 commits November 18, 2021 23:01
@unity-cchu
Update 2DRendererData_overview.md
a0f6af7
@Sam-Unity
Just adding tagging
1d8c050 
Added `` tags around CameraSortingLayerTexture.
Sam-Unity
Sam-Unity approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@Sam-Unity Sam-Unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving previous edits and final edit.

@phi-lira phi-lira merged commit a6fa10a into master Dec 9, 2021
@phi-lira phi-lira deleted the 2d/CameraSortingLayerTexture-Docs-Update branch December 9, 2021 09:44
@unity-cchu unity-cchu mentioned this pull request Jan 28, 2022
Merged
1 task
@unity-cchu
Copy link
Contributor Author

Backport 2021.2: #6887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sam-Unity Sam-Unity Sam-Unity approved these changes

+1 more reviewer

@phi-lira phi-lira phi-lira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-2021.2 universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unity-cchu @phi-lira @Sam-Unity