Skip to content

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Nov 26, 2021

Purpose of this PR

https://jira.unity3d.com/browse/ANT-302

  • Compare results with nightly from same base commit + List findings in this document

Testing status

@github-actions github-actions bot added the sdet label Nov 26, 2021
@theopnv
Copy link
Contributor Author

theopnv commented Nov 29, 2021

Comparison of failing tests with master: https://docs.google.com/document/d/1uyLlcf_0TZ4PEPJUJEaxYwJ9USdH33aDtaRF5UFLOAM/edit?usp=sharing
All failing jobs are matching master (from november 26th), or are not run on master.
Conclusion: Changing the image does not require a change of reference images.

@theopnv theopnv marked this pull request as ready for review November 29, 2021 10:05
@theopnv theopnv requested a review from a team as a code owner November 29, 2021 10:05
@theopnv theopnv requested a review from tomzig16 November 29, 2021 10:05
@theopnv theopnv merged commit b5156f1 into master Nov 29, 2021
@theopnv theopnv deleted the ant/urp/android/use-s21 branch November 29, 2021 12:55
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theopnv theopnv mentioned this pull request Nov 30, 2021
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theopnv theopnv mentioned this pull request Nov 30, 2021
theopnv pushed a commit that referenced this pull request Dec 1, 2021
theopnv pushed a commit that referenced this pull request Dec 1, 2021
@theopnv
Copy link
Contributor Author

theopnv commented Jan 3, 2022

I'm planning the backports for this PR, and realized on 10xx and 7xx we are still using hikeys (I think), since we're using Unity::mobile::android. Is that intenteded/is it planed to replace these with samsung devices (S21s?) @tomzig16

@tomzig16
Copy link
Contributor

tomzig16 commented Jan 3, 2022

I'm planning the backports for this PR, and realized on 10xx and 7xx we are still using hikeys (I think), since we're using Unity::mobile::android. Is that intenteded/is it planed to replace these with samsung devices (S21s?) @tomzig16

I had left hikeys as we used to have small amount of the devices at the time of making the PR. Now if we have enough s21s we could move, but I believe there might be a reference image failure or two. When I was moving from hikeys it was a failure in terrain test on vulkan due to small rasterization difference which was solved by updating reference images so I'd expect something similar on these backports. @theo-pnv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants