Skip to content

[ANT-333] Update git hooks' formatting command + docs #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 30, 2021
Merged

[ANT-333] Update git hooks' formatting command + docs #6417

merged 2 commits into from
Nov 30, 2021

Conversation

theopnv
Copy link
Contributor

@theopnv theopnv commented Nov 29, 2021 •
edited
Loading

Purpose of this PR

Companion PR: https://github.cds.internal.unity3d.com/unity/gfx-sdet-tools/pull/70

Testing status

  • Formatting job
  • Tested locally using git fork and the warning doesn't show up
  • Asked the developer who reported this originally to also verify the fix locally.

@github-actions github-actions bot added the sdet label Nov 29, 2021
theopnv
theopnv commented Nov 29, 2021
View reviewed changes
@theopnv theopnv marked this pull request as ready for review November 29, 2021 16:26
@theopnv theopnv requested a review from a team as a code owner November 29, 2021 16:26
@theopnv theopnv merged commit fcab96d into master Nov 30, 2021
@theopnv theopnv deleted the ant/333/update-formatting-command branch November 30, 2021 09:17
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theo-at-unity
Backport #6417
056d93f
@theopnv theopnv mentioned this pull request Nov 30, 2021
Merged
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theo-at-unity
Backport #6417
ad9de87
@theopnv theopnv mentioned this pull request Nov 30, 2021
Merged
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theo-at-unity
Backport #6417
da5790d
@theopnv theopnv mentioned this pull request Nov 30, 2021
Merged
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theo-at-unity
Backport #6417
fd5a587
@theopnv theopnv mentioned this pull request Nov 30, 2021
Merged
theopnv pushed a commit that referenced this pull request Dec 1, 2021
[2022.1] ANT Backports (#6427)
2a7942f 
* Backport #6417

* Backport #6408
theopnv pushed a commit that referenced this pull request Dec 1, 2021
[2021.2] ANT Backports (#6428)
fd135f7 
* Backport #6417

* Backport #6408
theopnv pushed a commit that referenced this pull request Dec 1, 2021
Backport #6417 (#6429)
16069cd
theopnv pushed a commit that referenced this pull request Dec 1, 2021
Backport #6417 (#6430)
769ef4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kivistikliis kivistikliis kivistikliis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported-7.x backported-10.x backported-2021.2 backported-2022.1 sdet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theopnv @kivistikliis @theo-at-unity