BatchRendererGroup test project splitMask support #6416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it to render black objects.
…g tests to fail randomly.
# Conflicts: # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BRGGameObjects/RenderBRG.cs # TestProjects/BatchRendererGroup_HDRP/Assets/SampleScenes/BatchRenderGroupRaw/BRGSetup.cs # TestProjects/BatchRendererGroup_URP/Assets/SampleScenes/BRGGameObjects/RenderBRG.cs # TestProjects/BatchRendererGroup_URP/Assets/SampleScenes/BatchRenderGroupRaw/BRGSetup.cs
|
It appears that you made a non-draft PR! |
sebbbi
approved these changes
Nov 29, 2021
TomasKiniulis
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Looks good to me if Yamato is passing: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/graphics%252Fhrnext-culling-bugfix/.yamato%252Fall-batchrenderergroup.yml%2523BatchRendererGroup_trunk/10202310/job
Need to have reference images updated now.
cinight
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Universal_BatchRendererGroup_trunk on this branch is green.
JussiKnuuttila
added a commit
that referenced
this pull request
Dec 7, 2021
* Ported BatchRendererGroup API tests to use the refactored culling callback API. * BRGSetup.cs: added 64 bytes of zeros to beginning (convention). Causes it to render black objects. * BRGSetup.cs test case didn't setup inverse matrices correctly, causing tests to fail randomly. * Updated BRG test scripts for HDRP * Automated formatting patch to make Yamato pass * Update yamato generated refenrece images * Update yamato generated refenrece images for BRG_URP * Properly initialize drawCommandPickingInstanceIDs to null in the simple example. Co-authored-by: Sebastian Aaltonen <sebastian.aaltonen@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com>
JussiKnuuttila
added a commit
that referenced
this pull request
Dec 8, 2021
* Ported BatchRendererGroup API tests to use the refactored culling callback API. * BRGSetup.cs: added 64 bytes of zeros to beginning (convention). Causes it to render black objects. * BRGSetup.cs test case didn't setup inverse matrices correctly, causing tests to fail randomly. * Updated BRG test scripts for HDRP * Automated formatting patch to make Yamato pass * Update yamato generated refenrece images * Update yamato generated refenrece images for BRG_URP * Properly initialize drawCommandPickingInstanceIDs to null in the simple example. Co-authored-by: Sebastian Aaltonen <sebastian.aaltonen@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Sebastian Aaltonen <sebastian.aaltonen@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: MingWai Chan <mingwai@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR that adds splitVisibilityMask to BatchRendererGroup has landed in trunk. This PR fixes the BatchRendererGroup test projects to function with the latest version.