Skip to content

Conversation

JussiKnuuttila
Copy link
Contributor

  • Ported BatchRendererGroup API tests to use the refactored culling callback API.

  • BRGSetup.cs: added 64 bytes of zeros to beginning (convention). Causes it to render black objects.

  • BRGSetup.cs test case didn't setup inverse matrices correctly, causing tests to fail randomly.

  • Updated BRG test scripts for HDRP

  • Automated formatting patch to make Yamato pass

  • Update yamato generated refenrece images

  • Update yamato generated refenrece images for BRG_URP

  • Properly initialize drawCommandPickingInstanceIDs to null in the simple example.

Co-authored-by: Sebastian Aaltonen sebastian.aaltonen@unity3d.com
Co-authored-by: Tomas Kiniulis tomas.kiniulis@unity3d.com
Co-authored-by: MingWai Chan mingwai@unity3d.com

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

* Ported BatchRendererGroup API tests to use the refactored culling callback API.

* BRGSetup.cs: added 64 bytes of zeros to beginning (convention). Causes it to render black objects.

* BRGSetup.cs test case didn't setup inverse matrices correctly, causing tests to fail randomly.

* Updated BRG test scripts for HDRP

* Automated formatting patch to make Yamato pass

* Update yamato generated refenrece images

* Update yamato generated refenrece images for BRG_URP

* Properly initialize drawCommandPickingInstanceIDs to null in the simple example.

Co-authored-by: Sebastian Aaltonen <sebastian.aaltonen@unity3d.com>
Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com>
Co-authored-by: MingWai Chan <mingwai@unity3d.com>
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@JussiKnuuttila JussiKnuuttila merged commit b304e44 into 2022.1/staging Dec 8, 2021
@JussiKnuuttila JussiKnuuttila deleted the graphics/hrnext-backport-splitmasks-to-2022-1 branch December 8, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants