Skip to content

Conversation

elizabeth-legros
Copy link
Contributor

Checklist for PR maker

  • [x ] Have you updated the changelog? Each package has a CHANGELOG.md file.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?
There was a bug in the Shader Graph import process which would treat warnings and errors as both being shader-breaking errors and thus a warning in the graph would cause the fallback error shader to display.

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Checked new UI names with UX convention
  • C# and shader warnings (supress shader cache to see them)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)
Added automated tests to the test project to verify warnings will not break shaders while errors still will

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline

@alindmanUnity alindmanUnity merged commit 5c135fa into master Apr 28, 2020
@alindmanUnity alindmanUnity deleted the shadergraph/bugfix-1186867 branch April 28, 2020 21:46
elizabeth-legros added a commit that referenced this pull request Apr 28, 2020
* Adding in check for error in graph to allow warnings to not break graphs and subgraphs

* Adding changelog

* retry to push changelog

* readd of update to changelog

* Adding graphics test for warnings and errors

* Edited CHANGELOG.md

* removing graphics test for shadergraph since it relies on a graph outputting an error and was more to teach me how to add a graphics test in the first place

* update code

Co-authored-by: Elizabeth LeGros <elizabeth.legros>
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request Jun 8, 2020
* Add isHidden flag for Blocks

* Add Universal SpriteColor block for upgrades (happy-json)

* Add isHidden flag for Blocks

* UpdateActiveBlocks on block deletion

* Fix requirements from Blocks

* Update HDRenderPipelineAsset.asset (#210)

* Improve block requirement handling

* Fix preview target

* Fixed volume debug menu in playmode (#149)

* Refresh widgets in play mode. Added doc. Reduced refresh rate

* Changelog

* Added some code doc

* Fix refresh rate and scroll over hidden volumes in play mode

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fix fragment normal block descriptors

* Fix Sprite normals

* Fix Sprite normals

* Fixup after merge

* Handle SaveContext call on HDRP when no asset assigned

* Update data to new serialization

* Fix issue after merge

* Update change log

* Added a new test scene for physical camera DoF in Pathtracer (#211)

* Fix issue when creating new graphs

* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215)

* fix bug 1238155

* Update CHANGELOG.md

* Update HDRenderPipeline.cs

* Update HDRenderPipelineAsset.cs

* fix some issues with creating new shadergraphs

* fix uncaught merge issue

* Bump com.unity.testframework.graphics version

* Upgrade path for Unlit and PBR

* Bump test dependencies

* fix UTP reporter version

* Upgrade path for HDUnlit

* Fix block map for multiple target upgrades

* Fix warning in PCSS code when using Vulkan (#229)

* Fix warning

* changelog

* next utp reporter version

* Upgrade path for HDLit

* Upgrade path for Decal

* Upgrade path for Eye

* Copy more default values in MaterialSlot

* Fix decal register + obsolete cookie API (#195)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Fix decal shader

* Fixed HDRP cookie

* Update HDLightUI.cs

* correctly fix decal

* Update CHANGELOG.md

* Update ColorAdjustments.cs

* Update ShaderVariablesDecal.hlsl

* fix compil on 2020.1

* Update HDRP_Test_Def.asset

* add test for 3RT decal

* update decal test

* Upgrade path for Fabric

* Upgrade path for Hair

* Upgrade path for StackLit

* Fix for missing SlotMask bits on HDLit

* Add missing Vertex blocks for Decal

* Fix Block requirements for custom descs (mainline)

* Fix HairStrandDirection field (master)

* Fix shader property upgrade issue

* Implement Undo core and URP targets

* Implement Undo HDRP targets

* Fixup after merge

* Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244)

* Do code cleanup + bugfix shadow

* Update Upgrading-from-2020.1-to-2020.2.md

* Update LightLoopDef.hlsl

* Fixed issues with path traced SSS and accumulation. (#257)

* Add missing documentation for AOV API params (#254)

* Hdrp/public static sky (#253)

* Made the static lighting sky public so that users can change it by script for baking purpose.

* Update changelog

* Update HDAdditionalLightData.Migration.cs (#269)

* Cretae per-pipeline menu items

* Fix HairStrandDirection field

* Fix color property upgrade

* Remove old master node and target classes

* Revert old Pragma.OnlyRenderers change

* Add display names to blocks

* Add missing docs attributes (#271)

* Fixed an error about procedural sky being logged by mistake. (#273)

* Fixed an error about procedural sky being logged by mistake.

* Update changelog

* Fix quality settings UI and shadow mask UI (#122)

* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* Update HDRenderPipeline.cs

* fix typo

* fix typo 2

* Validate HD naming conventions

* Define StackLit lobe A conceptually the same as Lit lobe

* Updated raytracing async compute warning. (#274)

* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Remove unnecessary descriptor null checks

* Move SpriteMask block to URP namespace

* Add paths for block descriptors via attribute

* Fixed a null ref exception in static sky when the default volume profile is invalid. (#278)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Auto add/remove blocks when changing target settings

* Added SubScenes cache to be compatible with HDRP/staging (#287)

* Fix up after merge

* Fix drawing master from upstream node changes

* Fix up PreviewManager after merge

* Fix up after merge

* Fix target initiailization

* Support upgrading blockmaps from multiple targets

* merge of cross pipeline mvp into stack master v2 upgrade hdrp

* fixing bugs

* remove old function

* fixing some test code

* Shadergraph/bugfix 1186867 (#65)

* Adding in check for error in graph to allow warnings to not break graphs and subgraphs

* Adding changelog

* retry to push changelog

* readd of update to changelog

* Adding graphics test for warnings and errors

* Edited CHANGELOG.md

* removing graphics test for shadergraph since it relies on a graph outputting an error and was more to teach me how to add a graphics test in the first place

* update code

Co-authored-by: Elizabeth LeGros <elizabeth.legros>
Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>

* more bugfix, one on creation of minimalgraphdata and updating some testcode calls which used guid instead of objectid

* Minor fixes

* working on node updates and unknown node types

* replace unkown node with known node

* Add contextual menu for Context separators

* Rename PassDescriptor block masks

* Fix SG test project

* Bump importers

* Add upgrade path for VFX

* Fix VFX tests

* handling unknown json types

* Changes to get branch to compile

* Moved target and subtarget settings to Internal Inspector

* Remove temporary inspector

* Fix HDLit clip threshold

* Re-enable HD shader stripping for SG shaders

* Fix HD SG vertex modification

* Various HDRP test fixes

* Remove excess changes

* fixing various upgrade bugs

* maybe fixed validity/activity???

* [skip ci] fixing window handling issues with preview and BB, code cleanup

[skip ci]

* [Skip CI] Fix upgrade of AlphaClip / AlphaTest

* [Skip CI] Fix condition for HDRP transparent cull mode GUI

* [Skip CI] Fix shadeBaseUsingRefractedAngles GUI

* [Skip CI] Fix StackLit debug GUI conditional

* [Skip CI] Revert some unecessary changes

* [Skip CI] Fix sub window layout serialization

* [Skip CI] Fix compiling of downstream BlockNode

* [Skip CI] Pass connected nodes to GetFields (Fix HD test 1202)

* [Skip CI] Hotfix for previews

* [Skip CI] Fix Unlit zWrite upgrade for HDRP (Fix HD test 8104)

* [skip ci] Inspector: Fixed bug 1244134 and property visible in inspector after deletion

* Fixed bug 1244134 with precision settings on nodes

* Fixed 8105_b test material data

* [Skip CI] Add unit tests

* Fix 8104 materials

* Upgraded HDRP Test material version

* [Skip CI] Revert HDRP DXR test 902 reference

* [Skip CI] Fix HD DXR tests 101, 102, 103 and 900

* [Skip CI] Fix HD test 8103 - Wrong condition for depth post pass

* Updated HDRP Runtime Tests materials

* Updated DXR test materials

* Updated perf and template materials

* Updated HDRP Hybrid materials

* created active state to deal with weird isactive states

* removing some logic from grapheditorview that really belongs at graph level and grabbing fix for searcher

* Added behavior to hide inspector when nothing is selected

* code cleanup and test case fixing

* removed IHasSettings and moved subgraph/custom node settings to inspector

* Adding more types to HDRP target allowed nodes and fixing serialization helper bug

* fixing some vfx serialization issues and adding another node to the HDTarget

* Started to re-organize the HDRP subtargets

* Sg/stack master v2 upgrade hdrp fix preview (#398)

* WIP : converted to tracking most things by preview instead of node

* Fix for softlock when a non-compiling node exists on a graph

* WIP :  Fixed issues with Master Preview transform
Optimized property collection and timed node treatment

* Subgraph Previews working
Master node preview redraws when resized
Better early out of render code

* Moved preview mode computation to unified UpdateTopology()
Cleaned up code

* making diffusion profile material slot mark dependency on the asset and changing minimalgraphdata to acess serialized slots on legacy graphs to take this into account

* Fix for Default Block Node slots not affecting initial preview renders

* Fix for previews not rendering.
Also a bit of code cleanup

* fixes for node property drawers, selection with undo/redo  and inspector and reordering targets

* Fix for Virtual Texture usage

* Fixing issues with PBR passes referencing old sigular Normal rather than NormalWS/TS/OS

* fix function signature

* removed reference to old IHasSettings interface

* Fix for Duplicate Node and Copy/Paste exceptions that soft lock the graph

* Fix for redirect nodes

* fixing issue where orphaned edges would try and update active trees on deleted nodes

* Properly handle ShaderGraph failure when subgraph doesn't exist.

* Fix for issues after deleting a subgraph used by a graph.
Also cleaned up error messages generated by the asset importer dependencies in the case that the subgraphs never existed in the project.

* Disallow dragging block nodes into groups

* Continue to clean HDRP subtargets

* fixing bug where changing active targets after load would not update node activity/validity

* fixing bug where material slots did not properly update on add/remove of edges

* Fixing 3 small issues in PreviewManager:
VT Textures were not set in URP preview
Occasional error spew from mismatched preview pass count
Incorrect profiling marker name

* make target property gui context a visual element

* fixing a PBR upgrade issue that would not set correct surface settings when upgrading a transparent master node

* Merge HDRP/staging into shader stack branch (#580)

* [9.x.x] Merge Hdrp/staging [Skip CI] (#366)

* Fixed an issue where AO override would not override specular occlusion. (#6222)

* Fixed an issue where AO override would not override specular occlusion.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Fixed an issue where Volume inspector might not refresh correctly in some cases. (#6252)

* Fixed an issue where Volume inspector might not refresh correctly in some cases.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* render XR mirror view only for camera with no RT (#6306)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Split set rendering feature set and API validity check (#6301)

* Split set rendering feature set and API validity check

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Hdrp/probe scale 1219246 (#6288)

* Fix when scale down < 0 all direction of box Influence Volume

* Update Change log

* Hdrp/fix/particle light shadows (#6111)

* Tried to fix particle light shadows

* Fixed particle shadows

* Updated changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Recording of accumulation motion blur and path tracing (#6114)

* Pt and accumulation motion blur recording

Fix merge issues

Fix merge issues #2

Bugfix: accumulation with one sample

Chengelog

Don't set the fixed-time in the subframe manager - should be set in the recorder

Properly set and reset the fixed time

Updated documentation

Small fix to make physics simulation work with scaled time / accumulation mb

Post rebase fixes and disable accumulation when using only one sub-frame

* Fix post merge issues

* hdrp resources asset file

* remove duplicate code

* Move most compute shaders to use multi_compile API (#6307)

* Squashed commit of the following:

commit ed9e485efc69a7949e34f0512666d522470dc73e
Author: FrancescoC-Unity <francescoc@unity3d.com>
Date:   Fri Mar 20 11:47:59 2020 +0100

    Revert "Squashed commit of the following:"

    This reverts commit 0dd46577be82abeaefc839cbcd9f3875b05d48e6.

commit 0dd46577be82abeaefc839cbcd9f3875b05d48e6
Author: FrancescoC-Unity <francescoc@unity3d.com>
Date:   Fri Mar 20 10:39:28 2020 +0100

    Squashed commit of the following:

    commit 0e1815814ce8204cfa42ae3050ba655fe769c550
    Merge: ac6809ec032 2b018dfe8a9
    Author: Sebastien Lagarde <sebastien@unity3d.com>
    Date:   Thu Mar 19 18:19:45 2020 +0100

        Merge branch 'master' into HDRP/staging

    commit 2b018dfe8a9f5f304e4b95d6279dda60f632c9dc
    Author: sebastienlagarde <sebastien@unity3d.com>
    Date:   Thu Mar 19 18:19:02 2020 +0100

        Merge Hdrp/staging (#6293)

        * Custom pass cleanup (#5507)

        * Fix custom pass cleanup issue with multiple volumes

        * Updated changelog

        * Delay discard of fragments during decal projection (#5283)

        * Delay discard of fragments during decal projection

        Metal Shading Language declares that fragment discard invalidates
        derivatives for the rest of the quad, so we need to reorder when
        we discard during decal projection, or we get artifacts along the
        edges of the projection (any partial quads get bad partial derivatives
        regardless of whether they are computed implicitly or explicitly).

        * Better re-arrangement of decal code

        * Update TerrainLitPasses.hlsl

        * Update TerrainLitPasses.hlsl

        * Update TerrainLitPasses.hlsl

        * Update ShaderPassDecal.hlsl

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fixing unnecessary memory allocations in the ray tracing cluster build and Updating the screen shots for the ray tracing tests (#5465)

        * Fixing unnecessary memory allocations in the ray tracing cluster build
        Updating the screen shots for the ray tracing tests

        * Update test scene and screenshots

        * - Discarding the ray tracing history for AO, reflection, diffuse shadows and GI when the viewport size changes.
        - Update and disable some tests that still  need to be updated

        * Add a counter for ray tracing frame index and update screenshots

        * Fixing the Area Shadows Denoiser Test

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Change the default volume used by the ray tracing tests to make them work again (#5510)

        * Change the default volume used for the ray tracing tests, fixes the tests back.

        * Fix access to the ray tracing frame index in ray tracing ambient occlusion (doesn't change behavior)

        * Missing term in the ray tracing frame index access (#5511)

        * Fix colum headers (#5517)

        * Fix colum headers

        * Update CHANGELOG.md

        * Rename post formats (#5505)

        * Renamed the post processing format to the new convention

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fixed the first frame flash with auto exposure (#5491)

        * Fixed flashes with low and high exposure scenes when Automatic Exposure is in use

        * Moved postfx history reset to per-camera reset

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update DefaultSettingsVolumeProfile.asset

        * Hdrp/small enhencements for DXR (#5493)

        * Add Warning for DXR and AsyncExecution in FrameSettings

        * move restarting at end of all fix in wizard for DXR

        * Update CHANGELOG.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Hdrp/update default scenes (#5485)

        * Replace default scenes with scene prepared for scene-template

        * Update of DefaultSettingsProfile

        * Update DXR scene

        * Add ScreenSpaceShadow to Camera's default FrameSettings

        * Update CHANGELOG.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Refactoring pre-existing materials to share code between rasterization and ray tracing (#5441)

        * Refactoring pre-existing materials to share code between rasterization and ray tracing
        Update the test scene

        * update changelog

        * Changing the color of an unlit in the reflection test scene

        * review corrections

        * Fixing unlit shader graph

        * Fix specular AA related issue

        * Update the reflection test

        * Fix an issue with debug display for ray tracing shaders
        Always use ray tracing frame index 0 for ray tracing tests
        Update tests screenshots
        Update ray traced reflection test scene

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Hdrp/staging thin (#5509)

        * Adding a REFRACTION_THIN model.

        * Fixed thin distance.

        * ... and fixed it.

        * Updated changelog, removed unused REFRACTION attrs from Fabric template.

        * Added a REFRACTION_THIN_DISTANCE macro.

        * Finished support for thin refraction.

        * Fixed LitTesselation (was missing thin refraction model).

        * fix issue when merging Refactoring of DoAlphaTest

        * Fixed an issue where passing a null ProfilingSampler would cause a null ref exception. (#5555)

        * Fixing the area shadow denoised test (#5544)

        * Fix leak in Sky when matcap view (#5556)

        * skip pre render sky in matcap view

        * changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix compilation issues of ApplyExposure on platforms that don't support VR (#5575)

        * Fix

        * changelog

        * Remove Preview from physically based sky

        * HDRP asset migration (#5580)

        * Initialize the HDRP asset version to the latest one so new assets are not migrated

        * Updated changelog

        * Hdrp/remove wind resources (#5578)

        * Remove wind resources

        Remove wind resources no longer used and containing big files

        * Update changelog

        * revert: Hdrp/update default scenes (#5485)

        * Fix issue with missing texture in test

        * Disable POM test in 1708 SG_OnSG as it is unstable

        * Add missing texture in runtime test

        * update caption for geometric normal debug in forward

        * add missing texture to runtime test

        * Create Textures.meta

        * fix SG on decal SG

        * Fixed an issue where ambient occlusion and screen space reflections editors would generate null ref exceptions when HDRP was not set as the current pipeline. (#5577)

        * Fixed a null reference exception in the probe UI when no HDRP asset is present. (#5582)

        * Fixed a null reference exception in the probe UI when no HDRP asset is present.

        * Indentation

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix custom pass outline (#5590)

        * Fixed custom pass outline resolution screen resolution dependent

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fixed a null reference exception in the HDRI Sky editor when no HDRP asset is present. (#5596)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix decal orientation when created from script. (#5592)

        * Fixed all migration classes to default to latest version so that Decals created by script to get migrated.

        Fixed decal created through context menu so that they get the proper rotation convention.

        * Update changelog

        * Moved the GetEnumLastValue to TypeInfo class

        * Updated super old test scenes to the proper latest version for decals

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Refactor of HDCamera (accesibility mostly) [Skip CI] (#5548)

        * Refactor of HDCamera

        - Made internal/private APIs that should not have been public
        - Fixed naming convention for private members
        - Moved everything by accessibility for clarity (public, internal, then private)

        * Added Doc and returned some API public.

        * Fix visibility of Density Volumes in reflections [Skip CI] (#5589)

        * Oblique projection frustum fix, first try

        * HDCamera frustum now recalculates near and far plane to avoid issues with oblique projection matrices.

        * Update changelog

        * Added comments

        * Indentation

        * Fixed camera relative position of frustum

        * Indentation

        * Fixed a null reference exception in Path Tracing, Recursive Rendering and raytraced Global Illumination editors when no HDRP asset is present. (#5597)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix ray tracing tests and add a test scene for lights and cookies in ray tracing (#5604)

        * expose StartSinglePass() and StopSinglePass() as public interface for XRPass (#5605)

        * Add missing custom pass API documentation (#5530)

        * Add missing custom pass API documentation

        * Fix doc spells and grammar

        * Stencil Refactor and Material migration fixes (#5581)

        * Remove leftover code

        * commit to switch machine

        * Remove hard coded stencil values in shaders

        * clear stencil

        * tmp commit, start of splitting decal in dbuffer and normal patchup

        * Make decal patching up run after GBuffer

        * Remove hardcoded value for SSS split lighting

        * Tmp commit to switch branch

        * Finalize build coarse stencil (with debug leftover and render graph NOT handled)

        * The AA bits (the easy one :-) )

        * split in two enums

        * Distortion vectors bit sorted

        * SSR bit

        * Motion vector bit

        * decals bit

        * Lighting bits

        * Use HTile for SSR

        * HTile SSS -> Incomplete, verify and test.

        * SSS fixes, but still not working (probably not HTile related, but main stencil)

        * Make decal patch normal work and remove stencil bit

        * some leftover fixes

        * was commited by mistake

        * Update materials

        * Revert "Update materials"

        This reverts commit 4a0de82ef51750b77546020d77ad6b5d773e60af.

        * Fix issues with MSAA and with migration

        * Forgot this out

        * update materials and maps

        * default materials

        * don't have SSR on unlit

        * Fix some leftovers

        * Renaming

        * Revert "update materials and maps"

        This reverts commit 103f1cb71d8fffa49b0c2ef57f1b41b36d0a3dbf.

        * Revert "default materials"

        This reverts commit 978740acd825562717a01437dcc0c74fc4cfefb0.

        * Fix migration

        * white line

        * Fix migration

        * Add render queue overide to the material placer.

        Also add PackageInfo.cs to HDRP, so the graphic tests can call it's internal methods and objects.

        * Default material post migration

        * com.unity.testing.hdrp post reimport

        * Updated materials from test

        * Disable tests that are to be updated or not needed anymore

        * Fix VFX issues  (To be fixed better by @PaulDemeulenaere )

        * Lit hardcoded default was off

        * Update VFX Test materials ( @PaulDemeulenaere for awareness )

        * Fix issue with stencil in TAA

        * Revert lighting data

        * revert light map data

        * Revert other lighting asset

        * Cleanup post processor.

        * Update DXR test material

        * Update commnets

        * Early (need testing) new migration workflow

        * Revert "Early (need testing) new migration workflow"

        This reverts commit 2db025002d66165dd00e90f5f5d3c944ed53f361.

        * Update post processor

        * Add manual option to migrate

        * Add dialog box

        Co-authored-by: RemyUnity <32760367+RemyUnity@users.noreply.github.com>

        * Push updated hdrp version in test project (#5617)

        * Push m_LastMaterialVersion update

        * Dont open dialog on yamato

        * Update test projects with recent stencil refector PR (#5618)

        * Update runtime test project

        * Create HDRPProjectSettings.asset

        * update DXR project

        * Revert "update caption for geometric normal debug in forward"

        This reverts commit 150d68279b891529be272b37f374c36b879646f4.

        * Run reimport during update (to avoid unwanted extra dialog during dialog box) (#5620)

        * Make user stencil bits public (#5616)

        * Expose bits to user

        * Update documentation

        * Update HDStencilUsage.cs

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Implement history rejection based on object velocity (#5532)

        * Implement history rejection based on object velocity

        * Update changelog

        * Fix an issue with ambient occlusion denoising being broken after adding the history rejection feature
        Adding the GPU Light type for history validation and rejection

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fixed initial state of material created through the context menu. (#5603)

        * Fixed an issue where materials newly created from the contextual menu would have an invalid state, causing various problems until it was edited.

        * Forgot DecalUI (for non shader graph decals)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update HDLightUI.Skin.cs

        * Cookie and planar atlas (#5518)

        * Added support for cookie atlas

        * Begin to move planar reflection into atlas

        * Added texture atlas for planar reflection probe plus a limit to on screen planar probes

        * Removed debug log

        * Fixed planar probe atlas scale issue and useless mipmap generation of the atlas

        * Refactor Texture2D atlas

        * Move ScaleBias for planar probes to a separate list

        * Fix cookie mode for directional lights

        * Added error log for non square cookie textures in the atlas

        * Fix merge

        * Fixed cookie atlas

        * Trying to fix area light cookies

        * Fixed area light cookie

        * Disable mipmap for non area light cookies

        * Added cookie atlas format control + fixed size warnings in HDRP cookie ui

        * Add resolution in Capture Settings reflection probe drawer

        * Removed warnings

        * Added the point light cookie texture array in the debug menu

        * Fix cookies in ray tracing + celestial body texture

        * Update dynamic light cookie screenshot

        * Update Animated cookie test + fix reflection probe texture format

        * Fix area light cookie

        * Update HDRP asset cookie and planar atlas sizes

        * Increase cookie atlas size for area light test

        * Simplify code

        * Fix cookie mip clamp

        * Fixed compilation and CG alloc

        * Added atlas layouting when there is no more space

        * Fix directional light cookie

        * Updated reference image of cookie area lights

        * Fix hardcoded format and cookie layout

        * Remove useless mip update

        * Fix area light cookie x flip

        * Added the debug exposure option for debug planar reflection atlas

        * reverted the fix for area light cookie x flip

        * Tried to simplify the code of the atlas

        * Update reference image

        * Added an error when max planar reflection probe on screen is reached

        * Fixed space parenthesis

        * Fixed mipmap not updated properly and area light cookie convolution temp texture format

        * Fixed atlas reset mips

        * Update tooltip and fixed cookie insertion order when there is no more space in the atlas

        * Enable exposure on cookie atlas debug

        * Fix debug overlap

        * Update reference image

        * Added migration code for the cookie atlas size and fixed point light cookie debug exposure

        * Added planar atlas size upgrade code

        * Updated planar reflection atlas message

        * Fixed resolution dependent cookie mip maps

        * Updated changelog

        * Fixed cookies for ray tracing

        * Fix cookie in the ray tracing light loop requested without being reserved

        * Clamp UV when doing the area light convolution

        * Update reference images

        * Remove debug symbols

        * Fixed area light convolution UV limit

        * Fixed half pixel clamp and updated reference images

        * Fixed planar reflection mip map edge bleeding and update reference images

        * Updated more image reference

        * Updated DXR cookie test scene

        * Fix default material transparent created with ZWrite enabled (#5621)

        * Fixed transparent material craeted with ZWrite enabled

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Hdrp/fix decal gizmo mouseover (#5626)

        * Remove controlID on projection direction of DecalProjector that conflict with other handles

        * Update CHANGELOG.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Hdrp/smallfixes lookdev (#5619)

        * Fix zoom being stuck around 0

        * fix crash forbiding view manipulation while using directly hdri without passing by an environment

        * Fix hitch in FPS displacement mode

        * Fix when user destroy the EnvironmentLibrary being used.

        * Update CHANGELOG.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Mask was never set for some debug pixel deferred shaders [Skip CI] (#5627)

        * Mask was never set

        * changelog

        * Added comments

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fixed an issue where creating decals at runtime could cause a null reference exception. (#5594)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Make APIs internal when they should be - 1 - [Skip CI] (#5531)

        * First pass of making APIs internal when they should be.

        * Indentation

        * Compilation fixes + review feedback.

        * Make APIs internal when they should be - 2 - [Skip CI] (#5533)

        * First pass of making APIs internal when they should be.

        * Indentation

        * WIP

        * Missing file

        * More

        * Revert some changes based on review feedback

        * Compilation fix

        * Compilation fixes + review feedback.

        * Updated HDUtils accessibility

        * More editor internals.

        * Better (not hardcoded) stencil handling in VFX (#5624)

        * Stencil update for vfx

        * Fix issues

        * fix missing templates

        * Avoid displaying material upgrader dialog on new project (#5631)

        * Don't run dialog on new project creation

        * skip only on first creation

        * Check file existence before showing dialog

        * typo

        * Push test materials after ZWrite PR (#5632)

        * Update HDRP_Test project

        * Update DXR test assets

        * Update run time tests

        * Discard invalid pixels when doing deferred lighting in compute (for camera stacking) (#5339)

        * Discard invalid pixels when doing deferred lighting in compute (as required for camera stacking)

        Small comment modification

        Update changelog

        * Use stencil buffer (instead of normals) to discard pixels in deferred compute

        * Remove not required if statement when binding the stencil

        * Small fixes to API visibility. (#5637)

        * Fixed some more public APIs to internal.

        * Made hasCustomRender public again.

        * Moved the tier defining from the asset to the concerned volume components. (#5519)

        * Alpha post-processing bugfixes and improvements (#5512)

        * Bug fix for post processing alpha with chrommatic aberation + minor fixes

        * Avoid double blending in DOF

        * Unit tests for alpha post-processing (TAA/DoF)

        Vulkan test images

        Vulkan meta files

        * Fix runtime tests (#5639)

        * Update runtime test screenshots

        * Update planar resolution

        * Add test (#5641)

        * fix material and project settings for VFX (#5642)

        * Revert change to GBuffer (normalbuffer usage) as it broke the raytracing code

        * Fix various issues with time and animated materials (#5480)

        * Fix various issues with time and animated materials

        * Changelog

        * Add getters

        * Only update time once per frame

        * Fix animation in reflection

        * Fix null ref exception

        * Re-applied code after impossible merge.

        * Comment change

        * Remove commented code.

        Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * fix graphic test (#5651)

        * renaming test 1901 -> 1451 and 1709 -> 1710

        * Update EditorBuildSettings.asset

        * Update 1710_Decals_Normal_Patch.png

        * update screenshots

        * update scene backgroud

        * Update manifest.json

        * Update decal patch screenshots

        * update 4052_TAA

        * Changing the tier system for a preset mode system and removing unnecessary options (#5646)

        * Changing from a tier management to a "mode" management for reflection and GI and removing the ability to enable/disable deferred and ray bining (they are now implied by performance mode)

        * Update the scene scenes

        * Update changelog

        * Fixing an instability with the light shadows in ray tracing

        * Update to light explorer (#5615)

        - Fixed SkyType display when no Visual Environment is present
        - Changed fog display to reflect the updated fog system
        - Changed Global to "Mode" as it is in Volume UI now.

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update 1710_Decals_Normal_Patch.png

        * disable TAA test for XR

        * Hdrp/add documentation tool (#5655)

        * Add the documentation tool to HDRP test project

        * Fixed window serialization

        * Update the documentation for the diffusion profile (#5654)

        * Update the documentation for the diffusion profile

        * Update Diffusion-Profile.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Add missing hdlight api (useVolumetrics) (#5652)

        * Add missing API to the HDAdditionalLightData

        * Updated changelog

        * Global Settings API doc. (#5649)

        * Fog Volume Component API doc. (#5645)

        * Debug Display API doc. (#5643)

        * Color picker API doc.

        * FullScreen Debug API doc.

        * Decal debug API doc

        * False Color debug API doc

        * Lighting Debug API doc

        * Material Debug API doc.

        * DebugDisplaySettings API doc.

        * Restored contact shadow fade debug.

        * API documentation for sky related classes. (#5640)

        * API documentation for sky related classes.

        * Document the PBR sky

        * Hdrp/small wizard fixes for dxr (#5633)

        * Add ScreenSpaceShadow to Camera's default FrameSettings

        * Forbid to atmpt creating default scene if the hdrpAsset is not right (we depend on its resources)

        * Update CHANGELOG.md

        * Add OS and Hardware check in wizard for DXR

        * Update CHANGELOG.md

        * Fixe typos

        * Add missing check on Shadows

        * Update Documentation

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Documentation (#5613)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix custom pass disable stencil (#5545)

        * Disable the strencil in custom passes when overwriting the depth and not writing into it

        * Updated changelog

        * Rephrase doc

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Add option to exclude camera motion contribution from motion blur (#5656)

        * Remove camera component from motion blur if desired

        * changelog

        * Documentation update

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Implement Semi-transparent Shadows for Point and Spot lights (#5490)

        * Make the shadow behavior for  transparent and transmissive objects more intuitive.

        * Update changelog

        * Implementing semi transparent ray traced shadows for point and spot light
        Adding a test scene for both cases
        Moving contact shadow ray tracing code to a seperate file
        Changing the direction of contact shadow rays to be coherent with the other shadows

        * update changelog

        * Update the test scenes

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * fix shader warning in termporal AA

        * Support semi-transparent shadows for unlit shader and unlit shader graph (#5663)

        * Not doing ray tracing when the stencil bit is off for ssr (#5665)

        adding a test case for it

        * Restored serialization of deprecated parameters to fix migration. (#5666)

        * Shadow Atlas is no longer allocated for area lights when they are disabled in the shader config file. (#5662)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Updated HDRP documentation (#5664)

        * Updated HDRP asset doc

        * Update the upgrade guide for cookies and planars

        * Added warning in the material sorting priority doc for depth write

        * Added a section about surface option properties for ShaderGraphs

        * Fix link name

        * Alpha output documentation (#5658)

        * Update documentation for HDRI-Sky-Backplate (AO) (#5670)

        * Avoid MRT Clear on PS4 [Skip CI] (#5675)

        * Avoid MRT Clear on PS4

        * changelog

        * Update HDRenderPipeline.cs

        * Update HDRenderPipeline.cs

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Change name of option (#5681)

        * More code share between inspector materials  (#5635)

        * Share stencil code for inspector materials (Akin to what happens in shadergraph)

        * changelog

        * Add comment and fix issue

        * Better handling of setting state (if not available, don't write it)

        * Update BaseLitGUI.cs

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Expose alpha cutoff material for ShaderGraphs (#5667)

        * Expose alpha clip to material UI for ShaderGraphs

        * Updated changelog

        * Replace #if by #ifdef

        * Fix debug menu bitfield (#5683)

        * Fixed runtime debug menu bitfield controls

        * Updated changelog

        * Hdrp/update default scenes (#5634)

        * Replace default scenes with scene prepared for scene-template

        * Update of DefaultSettingsProfile

        * Update DXR scene

        * fix missing profile in default scene dxr

        * Update CHANGELOG.md

        * Fix missing HDRI Sky references in DXR new scene

        * Fixed VFX Tests Default volume profile

        * Changed Default Volume settings to an empty one.

        * Missing volume asset files + update manifest and meta

        Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * - Fixed the radius value used for ray traced directional light. (#5682)

        - Fixed compilation issues with the layered lit in ray tracing shaders.
        - Changed the way the length parameter is used for ray traced contact shadows.
        - Added contact shadow test scenes

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * fixed XR autotests viewport size rounding (#5684)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Material samples bis (#5686)

        * Add ball

        * update Material samples #5638

        * Update CHANGELOG.md

        * Remove unused version property from Material

        * Updating the documentation for ray tracing (#5680)

        * Updating the documentation for ray tracing

        * review corrections

        * Fix mip slider reflectionprobe (#5689)

        * Remove the slider knob when the reflection probe preview has no mipmap

        * Updated changelog

        * edit VR documentation (#5685)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Better directional PCSS blur handling (#5688)

        * Use correct penumbra calculation for directional.

        * Update visual test

        * Need cleaning uo

        * Cleaning

        * screenshot update

        * Small cleanup

        * typo leftover

        * changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update 001-HDTemplate.png

        * Adding the initial implementation of sub-surface scattering (#5625)

        * Initial implementation of ray traced sub surface scattering
        Added a test scene for ray traced sub surface scaterring

        * Update changelog

        * Updating the tests

        * Update 8103_PrePostPass.unity

        * Remove unnecessary skip of material upgrade dialog box. (#5692)

        * Remove unnecessary skip of material upgrade dialog box.

        * Update changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix warning after metal fixup (#5704)

        * Various API doc update. (#5705)

        * Various doc + FrameSettings WIP

        * Finished frame settings API doc and added various other missing doc.

        Also made internal wrongly public API in HDRP

        * Fix density volume blend distance (#5698)

        * Fixed adjusting positive axis of Blend Distance slides the negative axis

        * Updated changelog

        * edit VR doc (#5699)

        * Hdrp/wizard update vr installation (#5706)

        * Add installatation checker in UsedPackageRetriever

        * Add PackageInstaller

        * Add better control on the displayed HelpBox

        * Update VR fixes

        * fix typo

        * Move Install Config Package Button above with HDRP Package info

        * Update CHANGELOG.md

        * Update documentation

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Removing unused alpha threshold depth prepass and post pass for fabric shader graph (#5711)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix default volume profiles location (#5710)

        * Ray traced reflection smoothness fade and fallback fixes. (#5700)

        * Fix fall back for ray traced reflections when denoising is enabled
        Make Smoothness Fade start work with ray traced reflections
        Fix the blend of reflections based on the weight
        Add the contact shadow test scenes back

        * Change the name of the weight function and add it to all shading models

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix iridescence color space (#5691)

        * Fix iridescence color space

        * Fixed compilation and updated test screenshots

        * fix test

        Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>

        * Fix Terrain Detail Mesh (stop to spam) [Require C++ PR] (#5690)

        * disable support of Terrain Detail

        Fix for error spam issue in HDRP: https://fogbugz.unity3d.com/f/cases/1211848/

        * Update CHANGELOG.md

        * Update HDRenderPipeline.cs

        * Update HDRenderPipeline.cs

        * [Waiting for C++] Disable probes in renderers (#5648)

        * Disable probes section in the Renderer editors

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Merge Hdrp/fix/case 1210058 to master (#5612)

        * Fix for 1210058 - NaNs at certain view angles

        Issue is caused by NaNs/INFs when computing basis on extremely thin (subpixel-width) geometry.  Putting some safeguards fixes the issue

        * Update CHANGELOG.md to reflect 1210058 fix.

        * Updated fix for issue #1210058

        Overwrite the UVs to fix the derivatives.

        * Updated fix for issue #1210058

        Make sure the UVs are zero if unused to fix the derivatives.

        * Undo last.change -- UV fix addresses NaNs

        Zeroing the unused UV1 channel on the material seems to do the trick.

        * Changelog adjustments to be moved

        Current version puts everything in HDRP, so there is no change in core.

        * Update CHANGELOG.md

        Reflect fix for NaNs

        * Fixed UV1 for lightmaps and detail maps.

        * update comment

        * Update NormalSurfaceGradient.hlsl

        Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Minor code cleanup

        * Added script documentation for SSR, SSAO (ray tracing), GI, Light Cluter, RayTracingSettings, Ray Counters, ray traced SSS andRecursive Rendering. (#5732)

        * Added script documentation for SSR, SSAO (ray tracing), GI, Light Cluster, RayTracingSettings, Ray Counters, ray traced SSS andRecursive Rendering.

        * udpate changelog

        * Implementation of ScreenSpaceReflections for Transparent materials (#4968)

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix HDRP duplicated frame settings (#5850)

        * - Added a fallback for ray traced area light shadows in case the material is forward or the lit mode is forward. (#5749)

        - Fixed a bug related to ray traced area light shadow history.

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix cookie index usage (#5871)

        * Hdrp/merge staging (#5943)

        * fix case 1205791 custom mesh issue (#5551)

        * fic case 1205791 custom mesh issue

        * Updated changelog

        * Added a call to Dirty() (#5420)

        * Added a call to Dirty()

        * Updated changelog

        Co-authored-by: Marc Templin <marctem@users.noreply.github.com>

        * Fix shadergraph analytics. (#5912)

        * Fix analytics.

        * Added changelog

        * Fix for case 1200161 Save as subgraph issue (#5503)

        * Fix for case 1200161

        * Edited CHANGELOG.md

        * Added comment to the code

        Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
        Co-authored-by: Marc Templin <marctem@users.noreply.github.com>

        * fix for unreported keyword bug (#5863)

        * Fixed fogbugz case 1197958 (#5671)

        * * Fixed fogbugz case 1197958.

        * * Updated CHANGELOG.md.

        * * Added spacing.

        * Added #if ENABLE_VR && ENABLE_VR_MODULE guard to XR code.

        *  Added Logic to Inject render pass to base renderer (#5901)

        *  Moved render pass injection code from Forward Renderer to ScriptableRenderer to be able to use for all renderers.

        *  added changelog

        * Disabling the GetDefaultRenderer() test for now until it is redone. (#5924)

        * [Yamato] [skip ci] Setting up master to run on 2020.1 (#5936)

        * added 2020.1 and fast to editors

        * added 2020.1/staging and fast to the rest of the files

        * [CI] Bors setup (#5841)

        * Create bors.toml

        * Update bors.toml

        * Update bors.toml

        * Update upm-ci-projects.yml

        * Create testcommit

        * Update bors.toml

        * adding trying trigger

        * add staging trigger

        * Delete testcommit

        * use squash merge

        * updating job that bors will run

        * [skip ci] update job that bors will run

        * Fixed MAD and RCP definitions in OpenGL. (#5922)

        Co-authored-by: Martin Thorzen <35328557+martint-unity@users.noreply.github.com>
        Co-authored-by: Marc Templin <marctem@users.noreply.github.com>
        Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>
        Co-authored-by: Zachary Diller <zackd44@gmail.com>
        Co-authored-by: thomas-zeng <49886741+thomas-zeng@users.noreply.github.com>
        Co-authored-by: Felipe Lira <felipedrl@gmail.com>
        Co-authored-by: Elvar Örn Unnþórsson <ellioman@ellioman.com>
        Co-authored-by: Liis Kivistik <kivistik.liis@gmail.com>
        Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com>

        * Fix whitespace

        * Misc fixes for the sky (#5974)

        * Static lighting sky now takes the default volume into account.

        * Fixed a leak in the PBR sky renderer.

        * Added a tooltip to the Ambient Mode parameter in the Visual Environment volume component.

        * Update changelog

        * Fixed null ref

        * Fixed an issue where having ambient mode set to dynamic might prevent the sky from being included in baking.

        * Forces an update of static sky when changing it in the Environment panel.

        * Fixed a problem with static sky when multiple skies are rendered at the same time.

        * Revert probes renderer PR (#5990)

        * Re-enable the probes section of renderers as it was not supposed to be disabled

        * Updated changelog

        * Fix a leak in the sky system. (#5967)

        * Fixed a cubemap leak when rendering previews for the first time.

        Also changed the debug name of the cubemap used for static lighting.

        * Update changelog.

        * Fixed an assert getting fired for the wrong reason.

        * Added a new light layer debug mode (#5942)

        * Moved lighting debug settings in containers

        * Light layers debug mode

        * Categories for Lighting Debug Panel Documentation

        * Light layers debug mode documentation

        * DebugUI.BitField now uses correct display names

        * Added unit test scene

        * Added changelog

        * Revert "Added changelog"

        This reverts commit a148fc2f97ef5288123f8f16485ba35f57b80f5e.

        * Updated CHANGELOG

        * Disable light layer debug mode after testing

        * reset all debug display settings

        * Renamed Shadow Layers option

        * Editable layer color. Defaults to color blind friendly colors

        * Fix when enabling an exclusive setting

        * Updated screenshots with new colors

        * Simplified variable API

        * Renamed class

        * Fix division by 0. Updated doc

        Co-authored-by: Adrien <adrien.detocqueville@gmail.com>

        * Hdrp/ssr toggle (#5996)

        * Added an "enable" checkbox to the SSR volume component.

        * Update changelog

        * Fix build when not in editor (#6024)

        * Fixed SSR in scene 1710 (#6028)

        * Fix merge error

        * Removed MSAA Buffers allocation when lit shader mode is set to "deferred only" (#6012)

        * Removed MSAA Buffers allocation when lit shader mode is set to "deferred only".

        * Removed MSAA SSS Buffer allocation when deferred only.

        * Invalid cast for realtime reflection probes (case 1220504) (#6026)

        * Invalid cast for realtime reflection probes (case 1220504)

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Aov Buffers tests (#6023)

        * Deactivate Preview Camera for HDCameraEditor to prevent it from rende… (#6022)

        * Deactivate Preview Camera for HDCameraEditor to prevent it from rendering in the render loop (case 1105163)

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Disable reflection probes section (#5994)

        * Disable reflection probes in the renderer components

        * Updated changelog

        * Remove version guard for terrainDetailUnsupported

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Integrate first skeleton of post process in render graph. (#5856)

        * Fixed execution error without raytracing

        * Prepare Prepass refacto

        * Another round of preparation

        * Renamed XRPassScope to XRSinglePassScope

        * RenderAfterPostProcess is now static

        * Add AfterPostProcess to RenderGraph (WIP)

        * AfterPostProcess implementation

        * Fixed wrong RTHandle allocation

        * Fixed light layers texture binding during deferred lighting pass

        * Implemented Post Process Final Pass with RenderGraph

        * Post merge fixes

        * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.

        * Fixed alpha in post processes

        * Fix DXR Tests (#6073)

        * Made ssr enable parameter true by default. (#6076)

        * Add comment (#6056)

        * Hdrp /tests/shuriken light module (#6021)

        * Add shurikent light module test

        * Fixed Simulate

        * Fix texts and image ratio

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Hdrp/pt7 (#5831)

        * Added support for anisotropy.

        * Tidied the code up, plus moved to correlated G term for aniso GGX.

        * Added anisotropic refractive sampling.

        * Disable path tracing for the shading graph preview camera.

        * Added support for alpha culling.

        * Fixed issue with transmission rays.

        * Updated Changelog.

        * Added support for punctual and directional light cookies.

        * Updated Changelog.

        * Added support for area light cookies.

        * Fixed bug with area cookies atlas not being properly generated when
        rebuilding library.

        * Made sure maxDepth > minDepth always, and added support for AO from mask.

        * Added support for transparent shadows.

        * Updated Changelog.

        * Toggling path tracing on/off does not reset iteration anymore.

        * Reverted change on enable, was causing minor issues.

        * Made sure we don't have transparent behaviour when shader is set to
        opaque.

        * Minor changes.

        * Tweaks on transparency behaviour.

        * Updated changelog.

        * Added path-tracing specific payload.

        * Added support for iridescence.

        * Updated Changelog.

        * Added multiple scattering compensation for specular.

        * Added Path tracing test.

        * PT test part 2.

        * Updated Changelog.

        * Added proper area light range attenuation.

        * Fixed issue with alpha clipping in ray-tracing.

        * Cosmetic.

        * Fix on the rect area light range.

        * In the editor, dragging manipulators around now resets accumulation.

        * Added material dirtiness tracking.

        * Does not apply intensity clamping to camera rays.

        * Reste PT iteration when saving a shader graph.

        * Added dirtiness tracking for acceleration structure and lights.

        * Added support for bg color.

        * Minor change to progress bar display.

        * Minor change to iteration counter, so that it never goes over the max.

        * Updated path tracing test.

        * Hdrp/rendergraph cleanup (#6083)

        * Fixed execution error without raytracing

        * Prepare Prepass refacto

        * Another round of preparation

        * Renamed XRPassScope to XRSinglePassScope

        * RenderAfterPostProcess is now static

        * Add AfterPostProcess to RenderGraph (WIP)

        * AfterPostProcess implementation

        * Fixed wrong RTHandle allocation

        * Fixed light layers texture binding during deferred lighting pass

        * Implemented Post Process Final Pass with RenderGraph

        * Post merge fixes

        * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders.

        * Fixed alpha in post processes

        * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle

        * Fixed decal normal patch pass

        * Fixed stencil resolve render pass

        * Fixed RenderDBuffer render pass function capturing variables.

        * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList

        * Various fixes of things that diverged compared to regular path.

        * Unified renderer list and texture invalid handle error.

        * Revert wrong change

        * post merge fix

        * Removed useless comment.

        * Missing doc

        * Hdrp /fix light prefab infinite reload on inspector gui (#6054)

        * fix infinite reload loop for light prefab

        * Update CHANGELOG.md

        * Fixed an issue where fog sky color mode could sample NaNs in the sky cubemap (#6027)

        * Fixed an issue where fog sky color mode could sample NaNs in the sky cubemap.

        * Update changelog.

        # Conflicts:
        #	com.unity.render-pipelines.high-definition/CHANGELOG.md

        * Fixed sampling of the sky texture in a more general way (not just fog)

        updated tests screenshots as well.

        * Missing screenshot

        * Fixed the issue properly by generating 7 mips of convolution.

        * Reverted screenshots

        * Reverted useless change.

        * Fix  culling group was not disposed error in the build (#5880)

        * Fix culling group was not disposed error in build

        * Fix culling was not disposed error in build

        * Updated changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix Material Samples : Revert correct GUIDs (#5875)

        * Revert correct GUID

        Change the GUID of the prefab to the correct one referenced in the scene

        * Fix fern material GUID

        * Hdrp/light multiplier (#6077)

        * Allow the light dimmer to get values higher than one

        * Changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update documentation typo (#5860)

        * Add warning and workaround instructions if XR single-pass is enabled after the first frame with XR SDK (#5853)

        * added warning and workaround instructions if XR single-pass is enabled after the first frame with XR SDK

        * edit VR doc

        * Updated CHANGELOG.md

        * Updated VR-Overview.md

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
        Co-authored-by: Sharlene Tan <43795986+sharlenet@users.noreply.github.com>

        * Remove info box on Visual Environment and replaced it with info on documentation (#6099)

        * Remove info box and update documentation

        * changelog

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Update 9801_ShurikenLightModule.png

        * Add missing exposure and mipmap sliders to the planar reflection probe preview (#5847)

        * Added planar reflection probe preview mip and exposure sliders

        * Updated changelog

        * Disable mip map as we don't have them anymore

        * Re-edited changelog

        * Use SRP macros in shader

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix upgrade cookie planar size (#6104)

        * Fixed the size of the planar reflection / cookie atlas after an upgrade of the HDRP asset

        * Updated changelog

        * Fixing merge issue for SSR transparent

        * Fix universal and yamato after merge.

        * fixuniversal after merge

        * renormalize files

        * Update 9801_ShurikenLightModule.unity

        * Make isEditorCameraPreview and sky public (#6147)

        * Update HDAdditionalCameraData.cs

        * Update SkySettings.cs

        * Update 9801_ShurikenLightModule.unity

        * Update HDAdditionalCameraData.cs

        * Update 9801_ShurikenLightModule.unity

        * Fixing ray tracing tests (#6158)

        * Fixed transparent SSR for shader graph. (#6163)

        * - Fixed transparent SSR for shader graph.

        * changelog

        * Added old graphics tests and modifications (#6143)

        * Update scenes

        * update blendstates

        * added OSX reference images

        * win reference images

        * fix lit light difference

        * Update blendstates-c-lit-unlit

        * disable check memory alloc due to ref probe issues

        * update ref images

        * rename test 1709 to 1711

        * rename test 1709 to 1711 - bis

        Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

        * Fix issue with blend mode and with keyword (#6164)

        * Fixed an issue with emissive light meshes not being in the RAS (#6174)

        * Hdrp/pt8 (#6090)

        * Added support for anisotropy.

        * Tidied the code up, plus moved to correlated G term for aniso GGX.

        * Added anisotropic refractive sampling.

        * Disable path tracing for the shading graph preview camera.

        * Added support for alpha culling.

        * Fixed issue with transmission rays.

        * Updated Changelog.

        * Added support for punctual and directional light cookies.

        * Updated Changelog.

        * Added support for area light cookies.

        * Fixed bug with area cookies atlas not being properly generated when
        rebuilding library.

        * Made sure maxDepth > minDepth always, and added support for AO from mask.

        * Added support for transparent shadows.

        * Updated Changelog.

        * Toggling path tracing on/off does not reset iteration anymore.

        * Reverted change on enable, was causing minor issues.

        * Made sure we don't have transparent behaviour when shader is set to
        opaque.

        * Minor changes.

        * Tweaks on transparency behaviour.

        * Updated changelog.

        * Added path-tracing specific payload.

        * Added support for iridescence.

        * Updated Changelog.

        * Added multiple scattering compensation for specular.

        * Added Path tracing test.

        * PT test part 2.

        * Updated Changelog.

        * Added proper area light range attenuation.

        * Fixed issue with alpha clipping in ray-tracing.

        * Cosmetic.

        * Fix on the rect area light range.

        * In the editor, dragging manipulators around now resets accumulation.

        * Added material dirtiness tracking.

        * Does not apply intensity clamping to camera rays.

        * Reste PT iteration when saving a shader graph.

        * Added dirtiness tracking for acceleration structure and lights.

        * Added support for bg color.

        * Minor change to progress bar display.

        * Minor change to iteration counter, …
PaulDemeulenaere added a commit that referenced this pull request Jul 21, 2020
* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP
sebastienlagarde pushed a commit that referenced this pull request Oct 5, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remov…
sebastienlagarde added a commit that referenced this pull request Oct 14, 2020
* Add alembic test to HDRP_DXR_Tests

* Update alembic reference images

* Use Yamato reference images

* XR test updated reference image

* Revert reference image for WindowsEditor. It looks like playmode_XR has
a different result than playmode and playmode_Rendergraph

* Modify alembic test to confirm alembic works with ray tracing by viewing
alembic mesh via ray traced reflection

* Set XR threshold multiplier to 1.5, based on other tests that have to
wait for frame

* Update WindowsEditor reference image

* updated most prefabs to not be prefab variants unecesssarily, updated diffusion profile for bamboo leaves, fixed wood normal map, rebaked, added new "medium" bake settings

* [CI] Updated .ymls to new revision

* Expose PointCacheAsset textures (#2030)

Currently there's no pCache property in vfx graph, this change exposes textures to make them usable instead of pCache.

More: https://forum.unity.com/threads/expose-point-cache-as-blackboard-attribute.856603/#post-6355635

* Fixed links and images

Fixed issues in the ToC, links in all docs and images in all docs.

* Fix Static-shader-analysis.md links.

Changed file name of Static-shader-analysis.md and fixed links.

* removed useless -preview.1

* Toc name change

Also amended links.

* TableOfContents name change.

* Universal/fixing changelog (#2090)

* removing duplicate Added sections

* removed accidental added text

* Fixed the dates issue

* Moved fixed to the right section

* Updated fontainbleau compatability and added relevant links

* Fix clear coat chagelog issues. (#2095)

* Renamed UI `Vector1` to `Float` / Renamed enum `Float` precision to `Single`  (V2) (#1979)

* rename precision from float to single

* rename vector 1 to float

* rename vector1 in the documentation

* Update Compositor-User-Guide.md

* Update Upgrade-Guide-10-0-x.md

* fix precision test

* add search synonym to upgraded node

* update precision test graph

* Fixed extra whitespaces and minor rewording

* Rename also all enum which a Vector1 inside to get correct string conversion as float

* Renamed Float.md and updated links to it

* Revert "Rename also all enum which a Vector1 inside to get correct string conversion as float"

This reverts commit 3d5fe9b48a1c2b7642b40327c5fea7a259016638.

* rename property type to have correct type display

* Update DiffusionProfileShaderProperty.cs

* Fix blackboard info name after merge of Antoie PR

* rename the uss color mode to keep correct banding color

Co-authored-by: Alex Lindman <alexandral@unity3d.com>
Co-authored-by: Sharlene Tan <sharlenet@unity3d.com>

* VFX Staging to Master for 10.1 (#1945)

* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick …
julienf-unity added a commit that referenced this pull request Oct 23, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remove unwanted fil…
julienf-unity added a commit that referenced this pull request Oct 25, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scr…
julienf-unity added a commit that referenced this pull request Oct 25, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scr…
sebastienlagarde pushed a commit that referenced this pull request Oct 25, 2020
* 10.2 fixes

* [VFX] harmonize position + fix API validation (#2365)

* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants