Skip to content

Conversation

skerys
Copy link
Contributor

@skerys skerys commented Dec 7, 2021


Purpose of this PR

Removing WS view direction from varyings broke shadergraph on built-in renderer. This PR makes built-in mirror the new behavior in URP (added with #5509), by moving the calculation of WS view direction into fragment shader.


Testing status

tested the BuiltinGraphicsTest_Lighting project locally
checked the behavior of the View Direction node
PR Shadergraph + ShaderGraph_BuiltIn_Lighting in yamato

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@skerys
Copy link
Contributor Author

skerys commented Dec 7, 2021

The two test failures in ShaderGraph on Win_DX11_Standalone_mono_Linear and VFX_URP on Win_DX11_playmode_mono_Linear happen in master too, all other tests passed

@skerys skerys marked this pull request as ready for review December 7, 2021 15:29
@skerys skerys requested a review from a team as a code owner December 7, 2021 15:29
Copy link
Contributor

@jessebarker jessebarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastienlagarde sebastienlagarde merged commit 8f88211 into master Dec 8, 2021
@sebastienlagarde sebastienlagarde deleted the shadergraph/builtin-world-space-view-dir-to-frag branch December 8, 2021 10:11
@sebastienlagarde
Copy link
Contributor

Does this need to be backport to 22.1? / 21.2? I see the original PR is from September

@skerys
Copy link
Contributor Author

skerys commented Dec 8, 2021

that PR took a while to land so only 22.1 backport is needed, will get on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants