Skip to content

[VFX/SG] Fix missing ObjectToWorld using Transform (to 2021.2) #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[VFX/SG] Fix missing ObjectToWorld using Transform (to 2021.2) #6579

wants to merge 2 commits into from

Conversation

PaulDemeulenaere
Copy link
Contributor

@PaulDemeulenaere PaulDemeulenaere commented Dec 13, 2021 •
edited
Loading

Purpose of this PR

Backport of #6475
⚠️ Can't be properly backported without #5817

Testing status

N/A

Comments to reviewers

Holding this change awaiting for another backport

@PaulDemeulenaere
[VFX/SG] Fix missing ObjectToWorld using Transform (#6475)
58ee559 
* Fix TransformNode usage in VFX

Missing World To Object matrix requirement

* *Update changelog

Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ?

* Better filtering of needed transform

Fix issue #6475 (comment)
Fix issue #6475 (comment)
# Conflicts:
#	com.unity.shadergraph/Editor/Data/Util/SpaceTransformUtil.cs
#	com.unity.visualeffectgraph/CHANGELOG.md
@PaulDemeulenaere
Special backport on 21.2
eb3626c 
The refactor from #5817 hasn't been backported
@Unity-Technologies Unity-Technologies deleted a comment from github-actions bot Dec 13, 2021
@PaulDemeulenaere PaulDemeulenaere mentioned this pull request Dec 13, 2021
Merged
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_2021.2
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_2021.2
/jobDefinition/.yamato%2Fall-shadergraph_builtin_lighting.yml%23PR_ShaderGraph_BuiltIn_Lighting_2021.2

VFX
/jobDefinition/.yamato%252Fall-vfx.yml%2523PR_VFX_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Shader Graph vfx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PaulDemeulenaere