[VFX/SG] Fix missing ObjectToWorld using Transform #6475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing World To Object matrix requirement
Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ?
VitaVFX
approved these changes
Dec 3, 2021
cdxntchou
approved these changes
Dec 8, 2021
Fix issue #6475 (comment) Fix issue #6475 (comment)
|
Double check locally at 65a242c (after adjustement) _basic_check.mp4 |
|
Awaiting for Yamato result before merge ⏳ |
|
The failure about VFX_URP are expected. |
PaulDemeulenaere
deleted the
vfx/fix/1363279-invalid-tangent-space-using-sg
branch
PaulDemeulenaere
added a commit
that referenced
this pull request
Dec 13, 2021
* Fix TransformNode usage in VFX Missing World To Object matrix requirement * *Update changelog Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ? * Better filtering of needed transform Fix issue #6475 (comment) Fix issue #6475 (comment) # Conflicts: # com.unity.shadergraph/Editor/Data/Util/SpaceTransformUtil.cs # com.unity.visualeffectgraph/CHANGELOG.md
|
Backport to 21.2 in blocked , see #6579 |
PaulDemeulenaere
added a commit
that referenced
this pull request
Dec 13, 2021
* Fix TransformNode usage in VFX Missing World To Object matrix requirement * *Update changelog Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ? * Better filtering of needed transform Fix issue #6475 (comment) Fix issue #6475 (comment) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
PaulDemeulenaere
added a commit
that referenced
this pull request
Jan 28, 2022
* Fix TransformNode usage in VFX Missing World To Object matrix requirement * *Update changelog Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ? * Better filtering of needed transform Fix issue #6475 (comment) Fix issue #6475 (comment) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
|
Cancelling the needs-backport-2021.2 because root change isn't available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix this case 1363279
The VFX relies on these require tranforms to populate local elementToWorld matrix (see here)
Testing status
Tested locally
Before
_before_fix_missing_need_transform.mp4
After
_after_fix_missing_need_transform.mp4
Comments to reviewers
See also this conversation
The changelog is actually only on VFX because I don't see another case where this missing declaration can cause an issue (maybe DOTS ?).