[VFX/SG] Fix missing ObjectToWorld using Transform (to 2022.1) #6581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix TransformNode usage in VFX Missing World To Object matrix requirement * *Update changelog Only in VFX, I don't see other cases where this fix is applicable, maybe DOTS ? * Better filtering of needed transform Fix issue #6475 (comment) Fix issue #6475 (comment) # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
…gent-space-using-sg
PaulDemeulenaere
requested review from
esmelusina
and removed request for
cdxntchou
|
Yamato is green, I double checked the change & resolution of conflicts in changelog, merging now. Thanks! |
PaulDemeulenaere
deleted the
2022.1/vfx/fix/1363279-invalid-tangent-space-using-sg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Backport of #6475
Testing status
Yamato ⏳
Comments to reviewers
N/A