[VFX] Fix Simulate (test to 10.x.x) #7137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[VFX] Fix Simulate (& Safety Net) (#5758) * *Add repro test * *Update test scene * *Add Simulate test & improve custom prewarm * Force sorting for a better coverage * *Update test location * *Update scene test & GraphicTest * *Update image reference retrieving result from yamato Some platform still missing * *Improve test coverage * *Update reference image * *Update missing image reference on OSX + missung meta # Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/22_Prewarm.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/ProjectSettings/EditorBuildSettings.asset
Not related to this PR, applying feedback from @JulienIgnace-Unity (will update image from Yamato)
…ssue-repro # Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/26_NonUnifomScale.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/26_NonUnifomScale.png
gabrieldelacruz
approved these changes
Mar 11, 2022
…ssue-repro # Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/22_Prewarm.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/22_Prewarm.png
|
Awaiting for Yamato, I will merge the internal in sync : https://github.cds.internal.unity3d.com/unity/ScriptableRenderPipelinePrivate/pull/381 |
PaulDemeulenaere
deleted the
10.x.x/vfx/test/1355385-simulate-issue-repro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
New test from https://ono.unity3d.com/unity/unity/pull-request/139027/_/2020.3/graphics/vfx/fix/1355385-force-flush-after-simulate
Testing status
Yamato 🟢
Comments to reviewers
https://ono.unity3d.com/unity/unity/pull-request/139027/_/2020.3/graphics/vfx/fix/1355385-force-flush-after-simulate⚠️ must be in sync