[VFX] Fix Simulate (& Safety Net) #5758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # TestProjects/VisualEffectGraph_URP/ProjectSettings/EditorBuildSettings.asset
Some platform still missing
+ missung meta
PaulDemeulenaere
requested review from
gabrieldelacruz and
ludovic-theobald
and removed request for
gabrieldelacruz and
ludovic-theobald
|
@gabrieldelacruz @ludovic-theobald I actually only need one review but I'm adding you two as reviewer to let you know informed when it has been merged. |
ludovic-theobald
approved these changes
Oct 25, 2021
|
C++ landed with |
PaulDemeulenaere
changed the title
PaulDemeulenaere
changed the title
|
Running locally because katana didn't provide the new editor version yet. |
PaulDemeulenaere
added a commit
that referenced
this pull request
Feb 9, 2022
[VFX] Fix Simulate (& Safety Net) (#5758) * *Add repro test * *Update test scene * *Add Simulate test & improve custom prewarm * Force sorting for a better coverage * *Update test location * *Update scene test & GraphicTest * *Update image reference retrieving result from yamato Some platform still missing * *Improve test coverage * *Update reference image * *Update missing image reference on OSX + missung meta # Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/22_Prewarm.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/ProjectSettings/EditorBuildSettings.asset
PaulDemeulenaere
added a commit
that referenced
this pull request
Apr 1, 2022
* Testing backport to check old behavior [VFX] Fix Simulate (& Safety Net) (#5758) * *Add repro test * *Update test scene * *Add Simulate test & improve custom prewarm * Force sorting for a better coverage * *Update test location * *Update scene test & GraphicTest * *Update image reference retrieving result from yamato Some platform still missing * *Improve test coverage * *Update reference image * *Update missing image reference on OSX + missung meta # Conflicts: # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/22_Prewarm.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D12/None/015_FixedTime.png # TestProjects/VisualEffectGraph_HDRP/ProjectSettings/EditorBuildSettings.asset # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsEditor/Vulkan/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/None/015_FixedTime.png # TestProjects/VisualEffectGraph_URP/ProjectSettings/EditorBuildSettings.asset * *Add missing meta * Temp delete all 019 reference file to force the generation with 2020.3 * *Update prewarm.png * Add 019_CustomSimulate in EditorBuildSettings * *Update 26_NonUniformScale to remove PBR Sky Not related to this PR, applying feedback from @JulienIgnace-Unity (will update image from Yamato) * *Update reference images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR adds a new graphicTest which is close to this fogbugz
Testing status
Yamato public 🟢
Yamato internal 🟠 (see mirror PR)
Comments to reviewers
This PR must be merged synchronously, this isn't a breaking change but it slightly change the image references.
It should wait for the merge of this C++ change: https://ono.unity3d.com/unity/unity/pull-request/132865/_/graphics/vfx/fix/1355385-force-flush-after-simulate