Skip to content

Conversation

pbbastian
Copy link
Contributor

Purpose of this PR

The "Skip Iterations" option on Bloom can cause the effect to not run at all due to the mip count being clamped too low. This causes the effect to never output anything in the bloom texture, thus ending up with whatever was in it when GetTemporaryRT returned it. But the rest of the pipeline still expects the bloom texture to contain valid data, and since GetTemporaryRT re-uses textures the contents would drastically change per frame.

On master this is fixed by #6369. We don't want to backport the new options, so instead we do this minimal fix.


Testing status

Verified bug locally by setting "Skip Iterations" too high, and then getting the scene view to render some frames while not in play mode.

@pbbastian pbbastian requested a review from ellioman February 17, 2022 11:49
@pbbastian pbbastian requested review from a team as code owners February 17, 2022 11:49
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@pbbastian pbbastian changed the title Fixed "skip iterations" issue on Bloom [2022.1] Fixed "skip iterations" issue on Bloom Feb 17, 2022
@phi-lira phi-lira merged commit 43c1353 into 2022.1/staging Feb 18, 2022
@phi-lira phi-lira deleted the 2022.1/universal/fix-bloom-iterations branch February 18, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants