[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369

ellioman · 2021-11-23T12:39:26Z

Purpose of this PR

Jira: URP-964

Users have been asking for more controls for Bloom quality and cost.
This PR addresses that by adding two options to the Bloom volume override:

Downscale (Half / Quarter)
Max Iterations (2...8)

We also deprecate the skipIterations option as maxIterations replaces it.

Before

After

Testing status

What has been tested

Tested locally in the Editor on OSX Big Sur 11.6

What needs testing

Standalone builds (OSX, Windows, iOS/Android)

Automatic Testing

Test scene 100_BloomHDR has been improved so that it uses the two new settings.
Additionally the Dirt Texture & Intensity has been enabled to make sure it tests that as well, which it did not do before.

Before

After

* "Add Renderer Feature" menu now uses the same menu as "Volume Overrides" * Universal Renderer help URL * Add page hash to help URL helper * Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects * Remove Name input for SSAO and Screen Space Shadows * Fix help URL for URP asset * Update change log * Fix change log * Remove `Attribute` suffix from attribute usage * Add docs for FilterWindow.Show * Move GetHelpURL to DocumentationUtils * Improve TryGetHelpURL interface

) * Upgraded Runtime/Materials/*.mat files. * Foundation CommonAssets/ *.mat files upgrade. * Foundation Scenes/ .mat files upgrade. * Foundation Scenes/ .renderTexture files upgrade. * Lighting CommonAssets/ .mat upgrade. * Lighting EditMode Assets .mat files upgrade. * Lighting Scenes/ .mat files upgrade. * Lighting Scenes/ .renderTexture files upgrade. * Terrain CommonAssets/ .mat files upgrade. * Terrain Scenes/ .mat files upgrade. * PostProcessing CommonAssets/ .mat files upgrade. * PostProcessing Scenes/ .mat files upgrade.

…g when a camera renders to a texture (#6274)

* update reference images * Update HDRP failing test reference images * Add HDRP Linux Vulkan test images * Rename UniversalHybridTest to BatchRendererGroup_URP * Move vulkan win ref images to None folder * Rename HDRP_HybridTests to BatchRenderGroup_HDRP * replace hybrid with BRG and add to nightly * Fix HDRP project name type * fix typo * Add .meta files of added reference images * remove playmode_xr * Update RenderBRG.cs scripts from hrnext-bugfix * Update BrgGameojbects hdrp reference images after master merge * Add vulkan to HDRP brg windows * use gpu for build, remove osx from ci * apply patch from the [Yamato] Formatting job * add BRG to nightly [skip ci] * remove the hybrid projects from repoconfig Co-authored-by: MingWai Chan <mingwai@unity3d.com> Co-authored-by: Tomas Kiniulis <tomas.kiniulis@unity3d.com> Co-authored-by: Sophia <sophia@unity3d.com>

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

…cale, Dirt Texture and Dirt Intensity

github-actions · 2021-11-23T12:39:39Z

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

github-actions · 2021-11-23T12:39:53Z

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Verasl

LGTM

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

ernestasKupciunas

Looks good. The changes work as intended.
My only concern is should the new settings be hidden under the Additional Properties @ellioman?
Other than that, I see no problems with this PR.

Tested using:
2022.1.0b1.2470
Revision: 2022.1/staging ea0f0219deed
Built: Mon, 06 Dec 2021 16:05:05 GMT

Tested platforms:
MacBook Pro (16-inch, 2021), CPU: Apple M1 Max, Memory: 64 GB, macOS: Monterey 12.0 - Metal
iPhone 13Pro Max, SoC: A15, iOS: 15.0.1 - Metal
iPad Air3, SoC: A12, iOS: 13.2.3 - Metal
Samsung Galaxy Z Fold2 5G, 10, Snapdragon 865 SM8250, Adreno 650 - Vulkan and Gles3
OnePlus Nord, 10, Snapdragon 765G SM7250-AB, Adreno 620 - Vulkan and Gles3
I don't have a Windows machine at home.

Also, in addition, I was running this Yamato test. It's an automated URP template scene, which runs on additional Android, Mac, Windows, iOS, and Linux devices. Yamato test link

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Documentation~/Images/Inspectors/Bloom.png

…6369

…6369 (#6899)

pbbastian and others added 12 commits November 18, 2021 14:49

Making intermediate render textures scale with the RenderScale settin…

3296d5d

…g when a camera renders to a texture (#6274)

Fix API is in the wrong state issue (#6331)

096b400

Tweaked bloom quality options

8fdcd3c

made new settings additional

f0eb0c5

Updated docs

34628cd

Merge branch 'universal/staging' into universal/better-bloom-settings

35a693d

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

Improving the Bloom Test scene so that it tests Max Iterations, Downs…

feaf154

…cale, Dirt Texture and Dirt Intensity

Renaming the Downscale enum to BloomDownscaleMode

2d2422f

Deprecating the skipIterations variable

d54c8a6

ellioman added the universal label Nov 23, 2021

ellioman requested a review from Verasl November 23, 2021 12:39

ellioman requested review from a team as code owners November 23, 2021 12:39

github-actions bot added the testing label Nov 23, 2021

Changelog

4e74779

Verasl approved these changes Nov 25, 2021

View reviewed changes

ellioman added 3 commits November 27, 2021 21:01

Merge branch 'universal/staging' into universal/better-bloom-settings

a17257a

Merge branch 'master' into universal/better-bloom-settings

0f4520b

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

Changelog

c20d4ae

ellioman requested review from a team as code owners November 29, 2021 08:49

ellioman changed the base branch from universal/staging to master November 29, 2021 09:16

sophiaaar removed the request for review from a team December 1, 2021 10:38

phi-lira removed the request for review from a team December 7, 2021 09:03

ellioman added 2 commits December 7, 2021 10:25

Merge branch 'master' into universal/better-bloom-settings

701f0e8

Updating bloom reference image for Android GLES3

7141a81

ellioman requested a review from a team December 12, 2021 14:57

ernestasKupciunas approved these changes Jan 5, 2022

View reviewed changes

Merge branch 'master' into universal/better-bloom-settings

012f00d

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md

ellioman requested a review from oleks-k January 25, 2022 08:46

Merge branch 'master' into universal/better-bloom-settings

0b3b51b

# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Documentation~/Images/Inspectors/Bloom.png

ellioman merged commit 96a4abd into master Jan 28, 2022

ellioman deleted the universal/better-bloom-settings branch January 28, 2022 13:15

ellioman added a commit that referenced this pull request Jan 29, 2022

Updating reference image for the Bloom test in XR that was missed in #…

1c449c5

…6369

ellioman added a commit that referenced this pull request Jan 29, 2022

Updating reference image for the Bloom test in XR that was missed in #…

2f6851a

…6369 (#6899)

ellioman mentioned this pull request Jan 29, 2022

[2022.2] Updating reference image for the Bloom test in XR that was missed in #6369 #6899

Merged

ellioman changed the title ~~[2022.1] Bloom: Downscale & Max Iterations options added~~ [2022.1] Bloom: Downscale & Max Iterations options added. URP-294 Feb 3, 2022

ellioman changed the title ~~[2022.1] Bloom: Downscale & Max Iterations options added. URP-294~~ [2022.1] URP-294 - Bloom: Downscale & Max Iterations options added. Feb 3, 2022

ellioman changed the title ~~[2022.1] URP-294 - Bloom: Downscale & Max Iterations options added.~~ [2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. Feb 11, 2022

This was referenced Feb 17, 2022

[2022.1] Fixed "skip iterations" issue on Bloom #7175

Merged

[2021.2] Fixed "skip iterations" issue on Bloom #7177

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369

[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369

Uh oh!

ellioman commented Nov 23, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Nov 23, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

Verasl left a comment

Uh oh!

ernestasKupciunas left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369

[2022.2] URP-294 - Bloom: Downscale & Max Iterations options added. #6369

Uh oh!

Conversation

ellioman commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose of this PR

Before

After

Testing status

What has been tested

What needs testing

Automatic Testing

Before

After

Uh oh!

github-actions bot commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 23, 2021

Uh oh!

Verasl left a comment

Choose a reason for hiding this comment

Uh oh!

ernestasKupciunas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ellioman commented Nov 23, 2021 •

edited

Loading

github-actions bot commented Nov 23, 2021 •

edited

Loading