Scene templates and default settings tweaks

[Chman]

Purpose of this PR

• Removed the old default scene system from the HDRP wizard and replaced it by scene templates (builtin feature in 2020.2). It comes with 2 scene templates for indoors and outdoors setups, with proper lighting and exposure setup (and a physical sky for outdoors to replace the old default HDRI sky) - both have a DXR variant that will only show in the template selection popup if DXR is enabled.
• Tweaked the default settings of HDRP:
  • Exposure Mode is now set to Automatic (Histogram).
  • Exposure Limit Min is now set to -4.
  • Exposure Limit Max is now set to +16.
  • Exposure limits have been reflected on the curve remapping mode as well.
• Cleaned up the doc to remove outdated info about the default scenes.

---

Testing status

Manual Tests:
Created new scenes using each available template. Note: these templates assume you have an HDRP asset setup already or that the Wizard has been ran at least once.

---

Comments to reviewers

Adding @JordanL8 to validate the template naming scheme and descriptions (look for the four *.scenetemplate files). I'm not entirely sure about the naming used here but I followed the one from the two hardcoded templates used with the builtin renderer.

[github-actions]

Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"

[iM0ve]

Concerns regarding Outdoor scene

• Physical sky is being used. This can cause confusion for beginners when they add objects below or near 0 altitude
  

• Fixed Directiontional light is using color filter, maybe we want to showcase Temperature mode instead?
  

• Fixed Sun intensity is 100 000 that translates to Bright day, but the scene looks dark, remaining of the evening. Maybe Limit Max exposure of 16 could be bumped down to 14 or 15
  

• Fixed We are using Dynamic Ambient mode. Some time ago we have a meeting where I recommended to make Dynamic by default. But we didnt do it because of the performance hit and considered it to be a bad practice. I have no issue with this one but want to clarify if this is still the case and we should recommend Static lighting or is it ok.
  

Concerns regarding Indoor scene

• Fixed Dynamic Gradient sky is used for Ambient lighting. Not sure if better recommended workflow could be using Visual Environment:None with black camera backround. Would this make sense performance/workflow wise?
  

General issues

• Doesnt repro HDRP wizard checkboxes no longer align. They work fine in staging
  

General Suggestions

• Fixed Rename Directional Light to Sun in outdoor scene
• Add HDRP default settings to the scene for discoverability. Effectively it wont do anything, but help people understand we have HDRP default settings applied. Priority -1
  

Test coverage:

• Create new Indoor scene
• Create new Outdoor scene
• Indoor and Outdoor in DXR
• Running HDRP wizard

[peeweek]

Dynamic Gradient sky is used for Ambient lighting. Not sure if better recommended workflow could be using Visual Environment:None with black camera backround. Would this make sense performance/workflow wise?

If I recall correctly, we had a lot of trouble with fog/volumetric fog when no sky was set in visual environment. (it was in 7.x package though)

[Chman]

Tweaked a few things:

• Indoors:
  • Changed the ambient mode to static.
• Outdoors:
  • Changed the ambient mode to static.
  • Exposure limit max to 14.
  • Renamed Directional Light to Sun.
  • Switched to color temperature for the sun.
  • Sun intensity to 110000 lux.

Notes:

• Regarding the wizard bug, I unfortunately cannot reproduce it on my end.
• For the Gradient Sky instead of None, see Thomas' reply. Perhaps it doesn't apply anymore, but because we don't have time to test everything at that point I'd rather play it safe.
• Adding HDRP default settings into the scene would be redundant, especially since scenes can be additively loaded.
• Moving to the PBSky is an unanimous request from all the artists here, and frankly it's miles ahead from the old default / borderline useless HDRI sky :) Eventually it would be nice for the HDRP team to find a trick to avoid this "under ground" rendering situation, but from the input we got the benefits outweigh the drawbacks in our opinion.

[Chman]

It should also be noted that I don't have any way of testing the DXR templates, any help is appreciated :)

[RSlysz]

lgtm

[sebastienlagarde]

I will check DXR template.

[iM0ve]

Issues I've found were fixed or discussed. I also tested DXR its exactly the same as regular templates, but has DXR SSR instead of regular SSR. We might want to add more features, even if they are turned off by default - for discoverability.

Found one new issue with unreliable reproduction. After running DXR wizard clicking on random scenes for 10-40 seconds will end up with an error message. This is an edge case, not sure if we can fix fast or just merge this version.
video link

[sebastienlagarde]

Found one new issue with unreliable reproduction. A
@iM0ve On my version of trunk (almost latest), I don't see the behavior that you show. Can't repro. If you repro it later, it is a bug for scene template team.

On DXR I have just added disable Raytracing Settings, but there is nothing to add more.

PR is good, thanks for that!

Merging