FIX: Fixed an issue where compiling Addressables with Input System package present would result in failed compilation due to IInputAnalytic.TryGatherData not being defined.

[ekcoh]

Description

Fixed an issue ISXB-1203 where compiling Addressables with Input System package present would result in failed compilation due to IInputAnalytic.TryGatherData not being defined. Apparently, compiling addressables is done in editor but UNITY_EDITOR is not defined, resulting in required method being excluded.

Testing status & QA

Tested to compile addressable with the provided repro project and Unity 6000.035f1, this failed.
Rested with the fix which results in successful compilation.

Overall Product Risks

Small-Medium, risk of having side-effects on some other variant of builds/versions.

• Complexity: Small
• Halo Effect: Medium

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

[Pauliusd01]

To me it seemed fine but I don't know whether there are any gotchas in the addressables area that I need to check. I've checked basic Input functionality and addressables build window functionality on U6 and 22.3. But I do have to mention that on 22.3, user project is difficult to downgrade and a brand new project doesn't even reproduce the issue for me before the fix. Maybe a difference in addressables version has something to do with it?

Added addressables QA - @harshala-rajesh for a second opinion

[harshala-rajesh]

I was able to reproduce the issue and verify the fix in branch in Unity Editor Versions 6000.0 and 6000.1 and addressables version 2.x
However with 2022.x and 2021.x - I was able to downgrade the project, I am not able to reproduce the issue both on addressables version 2.x and 1.22

[harshala-rajesh]

Also, the issue is not reproducible with addressables version 1.22 in 6000.x editors. So all good

[ekcoh]

Ignoring non required failure which seems env related: https://unity-ci.cds.internal.unity3d.com/job/46200063/logs