Skip to content

fix: Don't set the maximum frame time of UTP #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2022
Merged

fix: Don't set the maximum frame time of UTP #2088

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
459e3a6
fix: Don't set the maximum frame time of UTP
simon-lemay-unity Jul 28, 2022
0381cfc
Merge branch 'develop' into fix/no-max-frame-time
simon-lemay-unity Aug 17, 2022
52ba1fd
Merge develop into fix/no-max-frame-time
netcode-ci-service Aug 17, 2022
bd83125
Merge develop into fix/no-max-frame-time
netcode-ci-service Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,19 +1325,16 @@ public void CreateDriver(UnityTransport transport, out NetworkDriver driver,
#if MULTIPLAYER_TOOLS_1_0_0_PRE_7
NetworkPipelineStageCollection.RegisterPipelineStage(new NetworkMetricsPipelineStage());
#endif
var maxFrameTimeMS = 0;

#if UNITY_EDITOR || DEVELOPMENT_BUILD
maxFrameTimeMS = 100;
ConfigureSimulator();
#endif

m_NetworkSettings.WithNetworkConfigParameters(
maxConnectAttempts: transport.m_MaxConnectAttempts,
connectTimeoutMS: transport.m_ConnectTimeoutMS,
disconnectTimeoutMS: transport.m_DisconnectTimeoutMS,
heartbeatTimeoutMS: transport.m_HeartbeatTimeoutMS,
maxFrameTimeMS: maxFrameTimeMS);
heartbeatTimeoutMS: transport.m_HeartbeatTimeoutMS);

driver = NetworkDriver.Create(m_NetworkSettings);

Expand Down