fix: Don't set the maximum frame time of UTP #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
approved these changes
Aug 17, 2022
cdmazom
approved these changes
Aug 17, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons unknown, UTP's maximum frame time was configured to 100ms in the editor or development builds (instead of its default value of 0 which disables this feature). The maximum frame time makes it so that UTP will believe that no longer than the given time has elapsed between two updates.
That could be problematic if for some reason UTP is updated very infrequently. Say if it's only updated every second, then over five updates it will only consider that 500ms have elapsed, whereas the real time elapsed would be 5 seconds. That could make UTP miss sending heartbeats frequently enough to keep connections alive (which could lead to allocation timeouts if using Relay, for example).
I see no reason to keep this behavior in NGO, hence this PR is removing it.
Changelog
N/A (Not sure I'm actually fixing a real issue, or if it's just a theoretical possibility.)
Testing and Documentation