Dialogue system event fix #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from events in dialogue system
|
I think these fixes make a lot of sense, I'll just make a couple of small tweaks (tabs instead of spaces?? 😨 ), and merge. |
|
Ah nevermind, I know why you used the spaces. Let's leave them like that then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this PR linked to an issue? If so please link it here, if not please create one first, then link it.
#163 (comment)
Is there a forum thread linked to this issue? If so please link it here.
https://forum.unity.com/threads/dialogue-system-timeline-track.980712/page-2#post-6507001
How did you resolve this issue?
Used named methods to subscribe and unsubscribe from events. Also, took the opportunity to run this system through the input reader, rather than have it bypass the input reader.
How can it be verified that the issue has actually been resolved?
1.) put a console log in some event subscription
2.) trigger multiple cutscenes
3.) see that the event was only fired the expected number of times (1)