Skip to content

Conversation

@sighphyre
Copy link
Member

@sighphyre sighphyre commented Jun 28, 2024

Description

Ruff got an upgrade, the old ruff <path> command we use in the build no longer works. Now apparently it wants ruff check <path>

This new version of Ruff also raises a new lint, which is fixed in this PR.

Bonus points for fixing Ruff config in pyproject.toml that had been raising some warnings for some time

Fixes # (issue)

The build

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)\

How Has This Been Tested?

This PR + build pipeline

@coveralls
Copy link

Coverage Status

coverage: 97.043%. remained the same
when pulling d45782a on chore/fix-ruff-in-build
into b533c60 on main.

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighphyre sighphyre merged commit 568d85b into main Jun 28, 2024
@sighphyre sighphyre deleted the chore/fix-ruff-in-build branch June 28, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants