Skip to content

Conversation

@johncarl81
Copy link
Contributor

This fix allowed for inner classes to be imported as normal classes. This introduced an issue where private inner classes within the parent class are imported, causing a compilation error. For Instance:

package example;

import example.Parent.Child;  // <- Error

public class Parent {
    private static class Child {}
}

Causes a compilation error on the import of Child. To fix this, this PR suppresses the import of all inner classes if they are contained within the given class.

@UnquietCode UnquietCode merged commit cfeff11 into UnquietCode:master Feb 15, 2016
UnquietCode added a commit that referenced this pull request Feb 15, 2016
@UnquietCode
Copy link
Owner

Thanks for spotting this one. I made a few changes to your proposal to remove recursion and make the walk up the inheritance hierarchy more apparent. These will go out in a release soon. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants