Skip to content

Conversation

@rkurniawati
Copy link
Contributor

Hello,

Thanks for the helpful documentation on IBM watsonx.data connector!
I noticed a couple of small but potentially confusing typos in the comments, both of which are addressed by this PR.

Ruth

Signed-off-by: Ruth Kurniawati <ruth.kurniawati@gmail.com>
@Paul-Cornell
Copy link
Collaborator

Paul-Cornell commented Jun 16, 2025

Hello, @rkurniawati. I am happy to make these updates. For future reference, could you please provide some more information about why these are potentially confusing typos? Thanks!

@rkurniawati
Copy link
Contributor Author

A couple of the variable names in the comment don't match the code in associated the python code. I was able to figure out with a little debugging, but initially when I followed the instructions in the WatsonX connector documentation to create a python script that uses pyiceberg to connect to the Iceberg catalog, I ran into problems because of these wrong variable names. When I saw the listed environment variables, I created a .env file using the variables in the comment, but my script didn't work because the variable names in the instructional comment don't match the code in the python code.

@Paul-Cornell Paul-Cornell merged commit 5c58bf2 into Unstructured-IO:main Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants