Feat: add more output format for table inference #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qued
approved these changes
Oct 20, 2023
Contributor
qued
left a comment
qued
left a comment
There was a problem hiding this comment.
LGTM, just one typo and one suggestion/question.
Comment on lines
+387
to
+390
| if output_format: | ||
| result = table_transformer.run_prediction(example_image, result_format=output_format) | ||
| else: | ||
| result = table_transformer.run_prediction(example_image) |
Contributor
There was a problem hiding this comment.
Is hitting this model expensive? If so could we mock the call?
Co-authored-by: qued <64741807+qued@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses CORE-2307
UnstructuredTableTransformerModel.run_prediction:output_formatoutput_formatishtml, which is current behavior: output html string representation of the tabledataframe, which returns a pandas dataframe representation of the tableoutput_formatit returns a list of dictionaries: table cell format, the original output format from table transformerunstructured.model.tables.recognizeno longer acceptsout_htmlkwarg and it now only returns table cell format