feat: Refactor for local inference #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MthwRobinson
approved these changes
Jan 3, 2023
Contributor
MthwRobinson
left a comment
MthwRobinson
left a comment
There was a problem hiding this comment.
LGTM. I like UnknownModelException addition.
| @@ -1,12 +1,14 @@ | |||
| import pytest | |||
| from unittest.mock import patch | |||
| from unittest.mock import patch, mock_open | |||
Contributor
There was a problem hiding this comment.
Didn't know about mock_open before!
| return model_path, config_path, label_map | ||
|
|
||
|
|
||
| class UnknownModelException(Exception): |
benjats07
pushed a commit
that referenced
this pull request
Jan 10, 2023
Bumps [ipython](https://github.com/ipython/ipython) from 8.5.0 to 8.6.0. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@8.5.0...8.6.0) --- updated-dependencies: - dependency-name: ipython dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small factorization, primarily moving some of the api processing code out to where it can be reused.
Testing:
Functionality should be unchanged from a user perspective.
Tests should pass.
Curl should work while app is running locally:
make run-app-devpipeline-oer/sample-docsdirectory, or replacefake-oer.pdfwith the path to another pdf:Should succeed and return narrative sections.
Should succeed and return checkboxes (should be present if
fake-oer.pdfis used).Should fail with "unknown model" error message.