chore: remove detectron from setup.py #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MthwRobinson
reviewed
Jan 4, 2023
Contributor
MthwRobinson
left a comment
MthwRobinson
left a comment
There was a problem hiding this comment.
Couple questions/comments:
- Do you need to re-run
make pip-compilenow that detectron is removed fromsetup.py? - Should we add a
requirements-detectron2.txtfile to pin the detectron2 dependencies?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a non-pip dependency prevents
unstructured-inferencefrom being installed as a package from pypi, so this PR removes detectron2 from thesetup.pydependencies. Also removed the code to fail the install iftorchisn't installed -torchwill be installed withlayoutparser, and will be present when the user builds Detectron2 from source.Instructions have been updated to reflect the changes.