-
Notifications
You must be signed in to change notification settings - Fork 72
chore: remove tqdm output #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Think I added the bar to get information on the server side about progress on long tasks, not sure if is a good idea to remove it all |
yes, but this output is really not good for non-interactive tasks, like multi-process batch processing or in a server, which is really the intended use case. |
cragwolfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though i'd even make it a release so we can merge into unstructured
Yeah, true but people using locally could think that something isn't working (after all, this is the default output for them) Probably is needed to remove from here, but other approaches like using |
|
btw, here is what one request looks like when running in unstructured-api: the default should be not to have that. |
Removes progress bar output while processing pdfs and image elements.