feat: ocr when too many chars unrecognized #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cragwolfe
reviewed
Jan 8, 2023
MthwRobinson
reviewed
Jan 9, 2023
Contributor
MthwRobinson
left a comment
MthwRobinson
left a comment
There was a problem hiding this comment.
Tested this on a document that was previously returning cids and everything looks like it's working on this branch. Just one question from my end, I'll approve once you take a look at Crag's comments.
| return layout | ||
|
|
||
|
|
||
| def cid_ratio(text: str) -> float: |
Contributor
There was a problem hiding this comment.
Do you know if the cid pattern for unknown characters is specific to pdfminer? Or is that a universal convention?
Contributor
Author
There was a problem hiding this comment.
Looks like it's something pdfminer.six is doing: https://github.com/pdfminer/pdfminer.six/blob/20221105/pdfminer/converter.py#L235
cragwolfe
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain PDF documents have text blocks within their layout that contain text, but the text contains / consists of unrecognized characters, represented in the text as
(cid:n)wherenis an integer (ref, ref).Current logic accepts whatever text is present, only applying OCR in the case the layout text is
None. This PR changes the logic to also apply OCR in the case that > 50% of the characters are unrecognized.